Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow execution of raw RCON commands via WebSocket clients #388

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anklav24
Copy link

@anklav24 anklav24 commented Nov 5, 2024

No description provided.

@werewolfboy13 werewolfboy13 added core bug Bug related to the core SquadJS API patch Patch Change labels Nov 5, 2024
Copy link
Collaborator

@werewolfboy13 werewolfboy13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Thomas-Smyth you good with this? If the changes won't break anything.

@watchful-eyes
Copy link

@Thomas-Smyth you good with this? If the changes won't break anything.

Related PR:
#205

@anklav24
Copy link
Author

@Thomas-Smyth you good with this? If the changes won't break anything.

Related PR: #205

Got it! I actually like this option with super even more. The issue here is that the Socket IO plugin does not expose to use methods from the mail class, such as execute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core bug Bug related to the core SquadJS API patch Patch Change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants