Skip to content

Linkservice transactional 제거 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ckdals4600 merged 1 commit into from
Dec 20, 2025
Merged

Linkservice transactional 제거 #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/main/java/com/sofa/linkiving/domain/link/facade/LinkFacade.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import org.springframework.data.domain.Page;
import org.springframework.data.domain.Pageable;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

import com.sofa.linkiving.domain.link.dto.response.LinkDuplicateCheckRes;
import com.sofa.linkiving.domain.link.dto.response.LinkRes;
Expand All @@ -12,6 +13,7 @@
import lombok.RequiredArgsConstructor;

@Service
@Transactional
@RequiredArgsConstructor
public class LinkFacade {

Expand All @@ -37,14 +39,17 @@ public void deleteLink(Long linkId, Member member) {
linkService.deleteLink(linkId, member);
}

@Transactional(readOnly = true)
public LinkRes getLink(Long linkId, Member member) {
return linkService.getLink(linkId, member);
}

@Transactional(readOnly = true)
public Page<LinkRes> getLinkList(Member member, Pageable pageable) {
return linkService.getLinkList(member, pageable);
}

@Transactional(readOnly = true)
public LinkDuplicateCheckRes checkDuplicate(Member member, String url) {
return linkService.checkDuplicate(member, url);
}
Expand Down
5 changes: 0 additions & 5 deletions src/main/java/com/sofa/linkiving/domain/link/service/LinkService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import org.springframework.data.domain.Page;
import org.springframework.data.domain.Pageable;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

import com.sofa.linkiving.domain.link.dto.response.LinkDuplicateCheckRes;
import com.sofa.linkiving.domain.link.dto.response.LinkRes;
Expand All @@ -17,7 +16,6 @@

@Slf4j
@Service
@Transactional
@RequiredArgsConstructor
public class LinkService {

Expand Down Expand Up @@ -69,19 +67,16 @@ public void deleteLink(Long linkId, Member member) {
log.info("Link soft deleted - id: {}, memberId: {}", linkId, member.getId());
}

@Transactional(readOnly = true)
public LinkRes getLink(Long linkId, Member member) {
Link link = linkQueryService.findById(linkId, member);
return LinkRes.from(link);
}

@Transactional(readOnly = true)
public Page<LinkRes> getLinkList(Member member, Pageable pageable) {
Page<Link> links = linkQueryService.findAllByMember(member, pageable);
return links.map(LinkRes::from);
}

@Transactional(readOnly = true)
public LinkDuplicateCheckRes checkDuplicate(Member member, String url) {
return linkQueryService.findIdByUrl(member, url)
.map(LinkDuplicateCheckRes::exists)
Expand Down