Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#104 [fix] 바텀시트 이슈 해결 #107

Merged
merged 6 commits into from
Jan 18, 2024
Merged

#104 [fix] 바텀시트 이슈 해결 #107

merged 6 commits into from
Jan 18, 2024

Conversation

emjayMJkim
Copy link
Member

@emjayMJkim emjayMJkim commented Jan 18, 2024 •
edited
Loading

📑 Work Description

  • 바텀시트 이슈 해결

🛠️ Issue

📷 Screenshot

💬 To Reviewers

@emjayMJkim emjayMJkim changed the title Feature/#104 fix bottomsheet issue #104 [fix] 바텀시트 이슈 해결 Jan 18, 2024
minemi00
minemi00 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 빠르다 민정아 굿

stellar-halo
stellar-halo approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@stellar-halo stellar-halo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿입니다~ 👍👍

app/src/main/java/com/sopetit/softie/ui/dailyroutine/dailyroutineadd/DailyRoutineAddActivity.kt Outdated
@@ -37,7 +38,7 @@ class DailyRoutineAddActivity :

dailyRoutineAddViewModel.getThemeList()
dailyRoutineAddViewModel.setThemeId(6)
initSetDailyRoutineAdd()
// initSetDailyRoutineAdd()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

주석 삭제해주세요 ㅎㅎ

@pump9918 pump9918 self-requested a review January 18, 2024 15:38
pump9918
pump9918 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@pump9918 pump9918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

멋져요

@emjayMJkim emjayMJkim self-assigned this Jan 18, 2024
@emjayMJkim emjayMJkim added Pull Request pr 날림! 민정🦊 민정이가 작업함! fix Fix(디자인 등) labels Jan 18, 2024
@emjayMJkim emjayMJkim merged commit 643853e into develop Jan 18, 2024
1 check passed
@emjayMJkim emjayMJkim deleted the feature/#104-fix-bottomsheet-issue branch January 18, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minemi00 minemi00 minemi00 approved these changes

@pump9918 pump9918 pump9918 approved these changes

@stellar-halo stellar-halo stellar-halo approved these changes

Assignees

@emjayMJkim emjayMJkim

Labels
fix Fix(디자인 등) Pull Request pr 날림! 민정🦊 민정이가 작업함!
Projects
Softie Android
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 데일리 루틴 추가 바텀시트 이슈
4 participants
@emjayMJkim @stellar-halo @pump9918 @minemi00