Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#110 [fix] 버튼 터치영역 수정 및 웹사이트 연결 #112

Merged
merged 5 commits into from
Jan 19, 2024
Merged

#110 [fix] 버튼 터치영역 수정 및 웹사이트 연결 #112

merged 5 commits into from
Jan 19, 2024

Conversation

minemi00
Copy link
Member

@minemi00 minemi00 commented Jan 18, 2024 •
edited
Loading

📑 Work Description

  • 데일리루틴 추가하기 뷰, 설정뷰, 행복 루틴 추가하기(목록)뷰, 행복 루틴 추가하기 (상세)뷰 뒤로가기 버튼 터치영역 확장했습니다.
  • 루틴 편집시 나오는 라디오 버튼, 홈뷰에 있는 커머스, 설정 터치 영역 확장했습니다.
  • 모든 웹사이트 연결 했습니다.

🛠️ Issue

📷 Screenshot

Screen_recording_20240119_064021.mp4

💬 To Reviewers

다 확인하긴 했는데 호옥시 자기 뷰가 빠진거 같다면 얘기해주세요,,!

@minemi00 minemi00 added 민회🐹 민회가 작업함! fix Fix(디자인 등) labels Jan 18, 2024
@minemi00 minemi00 self-assigned this Jan 18, 2024
@minemi00 minemi00 changed the title #110 [fix] 뒤로가기 버튼 터치영역 확장하기 #110 [fix] 버튼 터치영역 수정 Jan 19, 2024
stellar-halo
stellar-halo approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@stellar-halo stellar-halo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

터치 영역이 작아서 불편했는데 좋습니다~!

emjayMJkim
emjayMJkim approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pump9918
pump9918 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했음다~

@minemi00 minemi00 changed the title #110 [fix] 버튼 터치영역 수정 #110 [fix] 버튼 터치영역 수정 및 웹사이트 연결 Jan 19, 2024
@minemi00 minemi00 merged commit 77dc151 into develop Jan 19, 2024
1 check passed
@minemi00 minemi00 deleted the feature/#110-all-back-button-touch-change branch January 19, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emjayMJkim emjayMJkim emjayMJkim approved these changes

@pump9918 pump9918 pump9918 approved these changes

@stellar-halo stellar-halo stellar-halo approved these changes

Assignees

@minemi00 minemi00

Labels
fix Fix(디자인 등) 민회🐹 민회가 작업함!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 버튼 터치영역 수정 및 웹사이트 연결
4 participants
@minemi00 @stellar-halo @pump9918 @emjayMJkim