Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#92 [hotfix] 닉네임 10글자 제한 #114

Merged
merged 6 commits into from
Jan 19, 2024
Merged

#92 [hotfix] 닉네임 10글자 제한 #114

merged 6 commits into from
Jan 19, 2024

Conversation

stellar-halo
Copy link
Contributor

📑 Work Description

  • 닉네임 10글자 초과시 경고문구 띄우는 로직 수정했습니다

🛠️ Issue

📷 Scre

Screenshot_20240119_090240_Softie
Screenshot_20240119_090245_Softie
enshot

💬 To Reviewers

  • 완벽하게 실시간은 아닙니다.. 🥹

@stellar-halo stellar-halo self-assigned this Jan 19, 2024
@stellar-halo stellar-halo added hotfix🚨 해결이 급한 부분 수정 Pull Request pr 날림! 강희🐬 강희가 작업함! labels Jan 19, 2024
pump9918
pump9918 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

디테일 고생 많았습니다~~

minemi00
minemi00 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막까지 수고하십니다!! 빠이팅

emjayMJkim
emjayMJkim approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stellar-halo stellar-halo merged commit f9fba27 into develop Jan 19, 2024
1 check passed
@stellar-halo stellar-halo deleted the feature/#92-hotfix-nickname-restrict branch January 19, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minemi00 minemi00 minemi00 approved these changes

@emjayMJkim emjayMJkim emjayMJkim approved these changes

@pump9918 pump9918 pump9918 approved these changes

Assignees

@stellar-halo stellar-halo

Labels
hotfix🚨 해결이 급한 부분 수정 Pull Request pr 날림! 강희🐬 강희가 작업함!
Projects
Softie Android
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 닉네임 입력 시 10자 이내 수정
4 participants
@stellar-halo @pump9918 @emjayMJkim @minemi00