Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#111 [hotfix] 데일리 루틴 추가 시 아무것도 누르지 않고 추가했을 때 앱 터짐 이슈 해결 #115

Merged
merged 3 commits into from
Jan 19, 2024
Merged

#111 [hotfix] 데일리 루틴 추가 시 아무것도 누르지 않고 추가했을 때 앱 터짐 이슈 해결 #115

merged 3 commits into from
Jan 19, 2024

Conversation

stellar-halo
Copy link
Contributor

@stellar-halo stellar-halo commented Jan 19, 2024 •
edited
Loading

📑 Work Description

  • 데일리 루틴 추가 시 아무것도 누르지 않고 추가했을 때 앱 터짐 이슈 해결
  • lateinit 때문에 생기는 문제였어서, adpater 생성 시 초기값 설정될 수 있게 코드 변경했습니다!

🛠️ Issue

📷 Screenshot

Screenshot_20240119_093447_Softie

💬 To Reviewers

코드가 너무 얼레벌레 같아서 죄송함니다,,

@stellar-halo stellar-halo added hotfix🚨 해결이 급한 부분 수정 강희🐬 강희가 작업함! labels Jan 19, 2024
@stellar-halo stellar-halo self-assigned this Jan 19, 2024
@stellar-halo stellar-halo added the Pull Request pr 날림! label Jan 19, 2024
minemi00
minemi00 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

널처리가 참 중요하군요,,, 수고하셨슴다!

emjayMJkim
emjayMJkim approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿굿

pump9918
pump9918 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stellar-halo stellar-halo merged commit 0a3e6ba into develop Jan 19, 2024
1 check passed
@stellar-halo stellar-halo deleted the feature/#111-daily-routine-first-item-add branch January 19, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minemi00 minemi00 minemi00 approved these changes

@emjayMJkim emjayMJkim emjayMJkim approved these changes

@pump9918 pump9918 pump9918 approved these changes

Assignees

@stellar-halo stellar-halo

Labels
hotfix🚨 해결이 급한 부분 수정 Pull Request pr 날림! 강희🐬 강희가 작업함!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hotfix] 처음 테마에서 루틴 추가 시 앱 터짐
4 participants
@stellar-halo @pump9918 @emjayMJkim @minemi00