Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#109 [hotfix] 온보딩, 바텀네비 수정 #120

Merged
merged 12 commits into from
Jan 19, 2024
Merged

#109 [hotfix] 온보딩, 바텀네비 수정 #120

merged 12 commits into from
Jan 19, 2024

Conversation

stellar-halo
Copy link
Contributor

@stellar-halo stellar-halo commented Jan 19, 2024 •
edited
Loading

📑 Work Description

  • 온보딩 이미지 파일 3배수로 갈아꼈습니다! -> 기기대응으로 코드 변경
  • 바텀 네비 용어 수정했습니다.
  • 안쓰는 icon 파일 삭제 했습니다
  • 로그인 시, 스토리텔링 넘어가는 부분 수정
  • 행복 루틴 상태바 색상 변경했습니다

🛠️ Issue

📷 Screenshot

💬 To Reviewers

@stellar-halo stellar-halo added hotfix🚨 해결이 급한 부분 수정 Pull Request pr 날림! 강희🐬 강희가 작업함! labels Jan 19, 2024
@stellar-halo stellar-halo self-assigned this Jan 19, 2024
minemi00
minemi00 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

파일 하나하나 바꿔끼느라 고생하셨습니닷!

emjayMJkim
emjayMJkim approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pump9918
pump9918 approved these changes Jan 19, 2024
View reviewed changes
Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔합니다

@stellar-halo stellar-halo merged commit 5fbbdcd into develop Jan 19, 2024
1 check passed
@stellar-halo stellar-halo deleted the feature/#109-hotfix-onboarding-bottom-navi branch January 19, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minemi00 minemi00 minemi00 approved these changes

@emjayMJkim emjayMJkim emjayMJkim approved these changes

@pump9918 pump9918 pump9918 approved these changes

Assignees

@stellar-halo stellar-halo

Labels
hotfix🚨 해결이 급한 부분 수정 Pull Request pr 날림! 강희🐬 강희가 작업함!
Projects
Softie Android
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[hotfix] 온보딩 뷰 QA
4 participants
@stellar-halo @pump9918 @emjayMJkim @minemi00