Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#108 [fix] 이슈 해결 #127

Merged
merged 7 commits into from
Jan 19, 2024
Merged

#108 [fix] 이슈 해결 #127

merged 7 commits into from
Jan 19, 2024

Conversation

emjayMJkim
Copy link
Member

@emjayMJkim emjayMJkim commented Jan 19, 2024

📑 Work Description

  • 설정: 상단바와 컨텐츠 간격 줄이기
  • 설정: 회원 탈퇴 화면 crying bear bear type에 맞게 바꾸기
  • 행복루틴: 삭제 모달("정말 삭제할까요") 가운데 정렬
  • 온보딩: 닉네임 초록색 -> 갈색 변경
  • 온보딩: 데일리 루틴 선택할 때 흰색 그라데이션 위, 아래로 간격 더 주기

🛠️ Issue

📷 Screenshot

💬 To Reviewers

@emjayMJkim emjayMJkim self-assigned this Jan 19, 2024
@emjayMJkim emjayMJkim added Pull Request pr 날림! 민정🦊 민정이가 작업함! fix Fix(디자인 등) labels Jan 19, 2024
Copy link
Contributor

@stellar-halo stellar-halo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines +135 to +154
// val binding: ItemOnboardingChoiceRoutineBinding =
// ItemOnboardingChoiceRoutineBinding.bind(holder.itemView)
// if (selectPosition.contains(position)) {
// binding.tvRoutineContent.setBackgroundResource(R.drawable.shape_gray100_fill_gray400_stroke_99_rect)
// } else {
// binding.tvRoutineContent.setBackgroundResource(R.drawable.shape_white_fill_gray000_stroke_99_rect)
// }
//
// binding.tvRoutineContent.setOnClickListener {
//
// if (selectedRoutineArray.size == MAXIMUM_ROUTINE_SELECTION) {
// if (selectPosition.contains(position)) {
// selectPosition.remove(position)
// setNoticeVisible(false)
// } else {
// setNoticeVisible(true)
// }
// } else {
// if (selectPosition.contains(position)) {
// selectPosition.remove(position)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 이 친구는 어떤 이슈인가요?

Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨슴다!

Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~~

@emjayMJkim emjayMJkim merged commit 6d0e599 into develop Jan 19, 2024
1 check passed
@emjayMJkim emjayMJkim deleted the feature/#108-fix-issue-fix branch January 19, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix(디자인 등) Pull Request pr 날림! 민정🦊 민정이가 작업함!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[fix] QA 이슈 해결
4 participants