Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#73 [feat] 프로필 생성 서버 통신 #77

Merged
merged 11 commits into from
Jan 17, 2024

Conversation

emjayMJkim
Copy link
Member

📑 Work Description

  • 프로필 생성 서버통신

🛠️ Issue

📷 Screenshot

💬 To Reviewers

기존에 Int로 되어 있던 bear type string으로 변경했습니다

@emjayMJkim emjayMJkim self-assigned this Jan 17, 2024
@emjayMJkim emjayMJkim added Pull Request pr 날림! Feat 새로운 기능 추가 민정🦊 민정이가 작업함! labels Jan 17, 2024
Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

토큰 바뀔때까지 테스트는 못해보겠지만..믿습니다ㅋㅋㅋㅋ

import kotlinx.serialization.SerialName
import kotlinx.serialization.Serializable

@Serializable
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

POST API의 첫 길잡이입니다


const val NONE = ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

text 사용 좋아요~

@emjayMJkim emjayMJkim changed the title #73 [FEAT] 프로필 생성 서버 통신 #73 [feat] 프로필 생성 서버 통신 Jan 17, 2024
Copy link
Contributor

@stellar-halo stellar-halo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM💞

Comment on lines +37 to +40
BROWN -> setLottieAnimation(R.raw.brown_hello)
GRAY -> setLottieAnimation(R.raw.gray_hello)
RED -> setLottieAnimation(R.raw.red_hello)
WHITE -> setLottieAnimation(R.raw.panda_hello)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿 서버에 맞게 바꾸는 게 저희도 유지 보수에 좋을 것 같아요!

Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

민정이는 막힘이 없다..!

@emjayMJkim emjayMJkim merged commit f196dd9 into develop Jan 17, 2024
1 check passed
@emjayMJkim emjayMJkim deleted the feature/#73-create-member-api branch January 17, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 추가 Pull Request pr 날림! 민정🦊 민정이가 작업함!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] 프로필 생성 서버 통신
4 participants