#74 [feat] 회원 탈퇴 서버통신 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pump9918
approved these changes
Jan 17, 2024
|
|
||
| private fun deleteAuth() { | ||
| val intent = Intent(requireActivity(), LoginActivity::class.java) | ||
| viewModel.isDeleteAuthResponse.observe(viewLifecycleOwner) { deleteSuccess -> |
There was a problem hiding this comment.
viewLifecycleOwner.. 아직 쓰면서도 정확히 어떤 기능을 하는지 잘 모르겠네요
There was a problem hiding this comment.
fragment에서 livedata를 옵저빙할 때 viewLifecycleOwner를 사용하면 fragment의 생명주기를 따르기 때문에 this에서 옵저버가 여러개 생기는 이슈를 방지하고 메모리 누수를 방지할 수 있습니다!
minemi00
approved these changes
Jan 17, 2024
|
|
||
| private fun deleteAuth() { | ||
| val intent = Intent(requireActivity(), LoginActivity::class.java) | ||
| viewModel.isDeleteAuthResponse.observe(viewLifecycleOwner) { deleteSuccess -> |
stellar-halo
approved these changes
Jan 17, 2024
Comment on lines
+37
to
+39
| sharedPreferences = | ||
| this.requireActivity().getSharedPreferences("user", Context.MODE_PRIVATE) | ||
| val bearType = sharedPreferences.getString("bearType", BROWN) |
There was a problem hiding this comment.
제가 다음 pr때 관련 UseCase 만들어 두겠습니다~!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Work Description
🛠️ Issue
📷 Screenshot
feat.delete.auth.member.mp4
💬 To Reviewers