Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#79 [fix] 자잘한 이슈 해결 #80

Merged
merged 5 commits into from
Jan 17, 2024
Merged

Conversation

emjayMJkim
Copy link
Member

📑 Work Description

  • 토스트 메시지 떠있는 시간 조정
  • 온보딩 뷰 루틴 리사이클러뷰 위치 조절
  • 배경화면 클릭시 hide keyboard

🛠️ Issue

📷 Screenshot

💬 To Reviewers

@emjayMJkim emjayMJkim self-assigned this Jan 17, 2024
@emjayMJkim emjayMJkim added Pull Request pr 날림! 민정🦊 민정이가 작업함! fix Fix(디자인 등) labels Jan 17, 2024
Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마무리까지 깔끔하다..!

fun Context.hideKeyboard(view: View) {
val inputMethodManager = getSystemService(Activity.INPUT_METHOD_SERVICE) as InputMethodManager
inputMethodManager.hideSoftInputFromWindow(view.windowToken, 0)
fun Context.hideKeyboard(view: View?) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

키보드를 숨기는 메소드인가요?? 멋져요

Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

민정이 완전 수고했으!!!

Copy link
Contributor

@stellar-halo stellar-halo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🧸

Comment on lines +43 to +46
override fun dispatchTouchEvent(ev: MotionEvent?): Boolean {
hideKeyboard(currentFocus)
return super.dispatchTouchEvent(ev)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿짭입니다! 제가 놓쳤는데 잘 잡아주셨네요

@emjayMJkim emjayMJkim merged commit 28ba7c7 into develop Jan 17, 2024
1 check passed
@emjayMJkim emjayMJkim deleted the feature/#79-fix-issue branch January 17, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fix(디자인 등) Pull Request pr 날림! 민정🦊 민정이가 작업함!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FIX] 1차 QA 자잘한 이슈 해결
4 participants