Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#72 [feat] 카카오 로그인 구현 #82

Merged
merged 30 commits into from
Jan 17, 2024

Conversation

stellar-halo
Copy link
Contributor

@stellar-halo stellar-halo commented Jan 17, 2024

📑 Work Description

  • 카카오 로그인 구현했습니다
  • 사용자가 회원가입 하면 온보딩 넘기는 로직도 같이 구현했습니다.

🛠️ Issue

📷 Screenshot

kakao.mp4

💬 To Reviewers

  • 카카오 디벨로퍼에서 본인의 해시키 값을 등록해야 합니다! -> local property에 있는 값도 삭제해주세요.

서버와 로그인 통신 성공 시, accessToken, refreshToken 저장
…akao-login

# Conflicts:
#	app/src/main/java/com/sopetit/softie/di/RepositoryModule.kt
#	app/src/main/java/com/sopetit/softie/di/RetrofitServiceModule.kt
@stellar-halo stellar-halo requested a review from minemi00 January 17, 2024 14:36
@stellar-halo stellar-halo self-assigned this Jan 17, 2024
@stellar-halo stellar-halo added the Pull Request pr 날림! label Jan 17, 2024
@stellar-halo stellar-halo added the 강희🐬 강희가 작업함! label Jan 17, 2024
Copy link
Collaborator

@pump9918 pump9918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 미쳤다... 고생했습니다!

<activity
android:name="com.kakao.sdk.auth.AuthCodeHandlerActivity"
android:exported="true"
android:launchMode="singleTask">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

singleTask가 어떤 역할인가요?

class KakaoLoginCallback(
private val onSuccess: (accessToken: String) -> Unit
) {
fun handleResult(token: OAuthToken?, error: Throwable?) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

꼼꼼한 분기처리..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 꼼꼼하다.. 몇개야

Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카카오 로그인 진짜 수고하셨습니당

} else {
Intent(this, LoginActivity::class.java)
}
// intent = Intent(this, LoginActivity::class.java)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 삭제부탁드립니다 히히

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅇㅊㅊ~

Copy link
Member

@minemi00 minemi00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

카카오 로그인 넘넘 수고하셨습니다 ㅠㅠㅠ 리드 최고 !!!!!!!!!1

import dagger.hilt.android.HiltAndroidApp
import timber.log.Timber

@HiltAndroidApp
class SoftieApplication : Application() {
override fun onCreate() {
super.onCreate()
KakaoSdk.init(this, KAKAO_NATIVE_APP_KEY)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드에 카카오가 들어가 있는게 묘하게 깐지나네요..

class KakaoLoginCallback(
private val onSuccess: (accessToken: String) -> Unit
) {
fun handleResult(token: OAuthToken?, error: Throwable?) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

진짜 꼼꼼하다.. 몇개야

<string name="finish_app_toast_msg">뒤로가기를 한 번 더 누르면 종료됩니다</string>

<!-- login -->
<string name="login_content">날 꺼내줘!</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커엽다..

@stellar-halo stellar-halo merged commit c857fd4 into develop Jan 17, 2024
1 check passed
@stellar-halo stellar-halo deleted the feature/#72-feat-kakao-login branch January 17, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pull Request pr 날림! 강희🐬 강희가 작업함!
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[feat] Kakao 로그인 작업
4 participants