Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] 회원 도전 루틴 조회 #299

Merged
merged 7 commits into from
Jun 27, 2024
Merged

[FEAT] 회원 도전 루틴 조회 #299

merged 7 commits into from
Jun 27, 2024

Conversation

Chan531
Copy link
Contributor

@Chan531 Chan531 commented Jun 26, 2024 •
edited
Loading

✨ Related Issue

📝 기능 구현 명세

image

  • 회원 도전 루틴 조회 (회원 도전 루틴이 존재하지 않을 때)

image

  • 회원 도전 루틴 조회 (회원 도전 루틴이 존재할 때)

image

  • 회원 루틴 조회 V2 테스트

🐥 추가적인 언급 사항

  • 회원 데일리, 도전 루틴 조회를 위한 ServiceRequestDto의 내용이 v1, v2 둘 다 memberId 하나로 동일한 상황인데 모두 통일시키는 거 어떤가요? 통일시킨다면 dto 4개가 1개로 줄어듭니다!

@Chan531 Chan531 added chan 찬 작업 feat 기능 개발 test 테스트 labels Jun 26, 2024
@Chan531 Chan531 requested a review from thguss June 26, 2024 08:38
@Chan531 Chan531 self-assigned this Jun 26, 2024
thguss
thguss approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다.
병합 전 204 코드 반환 관련은 클라이언트 쪽과 반드시 논의 부탁드립니다.

...n/java/com/soptie/server/memberroutine/controller/v2/MemberChallengeRoutineControllerV2.java Show resolved Hide resolved
...ie/server/memberroutine/service/dto/request/MemberChallengeRoutineAcquireServiceRequest.java Show resolved Hide resolved
.../server/memberroutine/service/dto/response/MemberChallengeRoutineAcquireServiceResponse.java Show resolved Hide resolved
...com/soptie/server/memberroutine/service/integration/MemberRoutineServiceIntegrationTest.java Outdated Show resolved Hide resolved
@Chan531 Chan531 merged commit 335d317 into develop Jun 27, 2024
2 checks passed
@Chan531 Chan531 deleted the feat/#282-member-challenge-routine branch June 27, 2024 08:33
@Chan531 Chan531 restored the feat/#282-member-challenge-routine branch July 5, 2024 09:00
@Chan531 Chan531 deleted the feat/#282-member-challenge-routine branch July 5, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thguss thguss thguss approved these changes

Assignees

@Chan531 Chan531

Labels
chan 찬 작업 feat 기능 개발 test 테스트
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] 회원의 도전 루틴 목록 조회
2 participants
@Chan531 @thguss