Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix: 하루 루틴 달성 초기화 기능 수정 #348

Merged
merged 11 commits into from
Oct 16, 2024
Merged

hotfix: 하루 루틴 달성 초기화 기능 수정 #348

merged 11 commits into from
Oct 16, 2024

Conversation

thguss
Copy link
Member

@thguss thguss commented Oct 16, 2024 •
edited
Loading

✨ Related Issue

📝 기능 구현 명세

  • 초기화되지 않는 문제를 해결했습니다.
  • 통합 테스트 코드를 작성하여 기능 정상 실행을 확인했습니다.

🐥 추가적인 언급 사항

  • 설정파일 내 property 값을 객체지향적으로 활용할 수 있도록 처리했습니다.
  • 도메인 VO 클래스로만 Entity에 접근 가능하도록 생성자를 추가했습니다. (이후 추가 작업이 필요하여 이슈 별도로 생성함)
  • config 패키지 파일이 분산되어 숨겨져 있어서 루트 위치로 이동했습니다.
  • scheme.sql 파일을 활용하여 softie 스키마를 바라보도록 초기 세팅했습니다.

@thguss thguss added hotfix test 테스트 labels Oct 16, 2024
@thguss thguss requested a review from Chan531 October 16, 2024 12:13
@thguss thguss self-assigned this Oct 16, 2024
Chan531
Chan531 approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@Chan531 Chan531 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@thguss thguss merged commit 852ed9f into develop Oct 16, 2024
2 checks passed
@thguss thguss deleted the hotfix/#346-init-routine branch October 16, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chan531 Chan531 Chan531 approved these changes

Assignees

@thguss thguss

Labels
hotfix test 테스트
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[HOTFIX] 루틴 달성 초기화 기능 수정
2 participants
@thguss @Chan531