[refact] #6 - 주문 품목 이력 조회 N+1 문제 해결 및 인덱싱 추가#7
Open
pilltong22 wants to merge 1 commit intodevelopfrom
Open
Conversation
- N+1 문제 JOIN 으로 개선 - INDEX 추가
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
ISSUE
Develop
주문 품목 이력 조회 API에서 품목 N개당 서브쿼리 7개가 실행되는 N+1 문제를 발견. 서브쿼리를 LEFT JOIN + GROUP BY로 통합하고, 누락된 인덱스를 추가.
Test
테스트 환경
GET /orders/40/item-history/latest문제점
sales_order_item_history.so_item_id에 인덱스 없음Before
After
Before vs After 비교