Chore: Wordings change for SmbConnectDialog #4545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SMB connections can use hostnames directly. Changed wordings to reduce confusion. Also rephrased "Enter Hostname Manually" instead of "Use Custom IP".
EmmanuelMess
previously approved these changes
Jan 10, 2026
Member
|
i changed the base branch because updates should first go to the release branch and then be re-merged into new hotfixes for the old release if needed. |
EmmanuelMess
approved these changes
Jan 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SMB connections can use hostnames directly. Changed wordings to reduce confusion.
Also rephrased "Enter Hostname Manually" instead of "Use Custom IP".
Issue tracker
Automatic tests
Manual tests
Done
Device: Pixel 4 Emulator
OS: Android 10
Build tasks success
Successfully running following tasks on local:
./gradlew assembledebug./gradlew spotlessCheck