-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] Timeline 네이밍 통일 #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
귀찮은 작업이었을텐데 고생하셨습니당 ㅠㅠ
1차 코드리뷰 반영 끝나면 다시 전체적으로 확인할게요 ~
app/src/main/java/org/sopt/dateroad/data/dataremote/datasource/TimelineRemoteDataSource.kt
Outdated
Show resolved
Hide resolved
...c/main/java/org/sopt/dateroad/data/dataremote/datasourceimpl/TimelineRemoteDataSourceImpl.kt
Outdated
Show resolved
Hide resolved
...src/main/java/org/sopt/dateroad/data/dataremote/model/response/ResponseNearestTimelineDto.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/data/dataremote/service/TimelineService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/data/mapper/todomain/ResponseNearestTimelineDtoMapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/domain/repository/TimelineRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/domain/repository/TimelineRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/type/TimelineBackgroundType.kt
Outdated
Show resolved
Hide resolved
같은 내용의 코드리뷰는 여러 번 안 썼으니 코드리뷰 보고 파일 전체적으로 확인해주시면 좋을 것 같아요 !! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아니 꼼꼼하게 본다구 봤는데 ㅠ 볼 때마다 네이밍 안 바뀐 게 나와요 ㅠ,,
민석오빠 한 번만 크로스 체크 부탁이용
Contract 부분에 네이밍 안 바뀐게 몇 개 보이는데 한 번만 확인해주시면 감사하겠습니당
app/src/main/java/org/sopt/dateroad/data/dataremote/datasource/TimelineRemoteDataSource.kt
Outdated
Show resolved
Hide resolved
...c/main/java/org/sopt/dateroad/data/dataremote/datasourceimpl/TimelineRemoteDataSourceImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/data/mapper/todomain/ResponseNearestTimelineDtoMapper.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/data/repositoryimpl/TimelineRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/data/repositoryimpl/TimelineRepositoryImpl.kt
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/enroll/EnrollContract.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/past/PastContract.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/past/PastContract.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/past/PastScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/past/PastViewModel.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
와 진짜 귀찮았을거 같은데 엄청 고생했겠네
수고링딩동!!
app/src/main/java/org/sopt/dateroad/domain/repository/TimelineRepository.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/domain/usecase/GetNearestTimelineUseCase.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/domain/usecase/PostTimelineUseCase.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/navigator/MainNavigator.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/timeline/TimelineScreen.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/timelinedetail/TimelineDetailScreen.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
하나만 수정하고 머지해주세요
고생하셨서요 ~
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢