-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] 에러 뷰, 로딩 뷰 추가 된 디자인 적용 #187
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뷰 수정이라.. 오랜만이네요..... 고생 많으셨습니당 ㅠㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니다 !
painter = painterResource(id = R.drawable.ic_empty_default), | ||
modifier = Modifier | ||
.fillMaxWidth() | ||
.padding(horizontal = 64.dp), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고정값 패딩을 주지 않고 기본 사이즈로 넣어주셔도 될 것 같아요! 요렇게 하려면 ContentScale.FillWidth
지워줘야함 ~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지워주세요 ㅠ
contentDescription = null, | ||
contentScale = ContentScale.FillWidth | ||
) | ||
Spacer(modifier = Modifier.height(30.dp)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
간격 없지롱 ㅋㅋ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
뭐야 여긴 없네 !!! 미아냉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
왜 안 지우냐능 ㅠㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
두 개만 수정하고 머지하세요 ~
contentScale = ContentScale.FillWidth | ||
modifier = Modifier | ||
.fillMaxWidth() | ||
.padding(horizontal = 64.dp), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
얘도 지워주세요!!! 패딩값!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
얼아라?? ContentScale.FillWidth 이거 지워주면 되는거 아니엇서요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ContentScale.FillWidth 이거 지워주면 이미지가 화면을 꽉 채우지 않고 현재 이미지 사이즈만큼의 크기를 가지게 되잖아요?? 그래서 패딩 따로 안 줘두 됨!!
contentDescription = null, | ||
contentScale = ContentScale.FillWidth | ||
) | ||
Spacer(modifier = Modifier.height(30.dp)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
왜 안 지우냐능 ㅠㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
디자인 변경사항 확인하구 수정하신 다음에 다시 알려주시와요
contentScale = ContentScale.FillWidth | ||
modifier = Modifier | ||
.fillMaxWidth() | ||
.padding(horizontal = 64.dp), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ContentScale.FillWidth 이거 지워주면 이미지가 화면을 꽉 채우지 않고 현재 이미지 사이즈만큼의 크기를 가지게 되잖아요?? 그래서 패딩 따로 안 줘두 됨!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
로딩뷰 이미지랑 마진 값 전체적으로 확인 부탁이 지금 안 맞는 거 조금 있는 것 같아오
modifier: Modifier = Modifier | ||
) { | ||
fun DateRoadErrorView() { | ||
val backDispatcher = LocalOnBackPressedDispatcherOwner.current?.onBackPressedDispatcher |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 변수 선언 안 하고 쓰면 안 되나용? 궁금해서 !
app/src/main/java/org/sopt/dateroad/presentation/ui/component/view/DateRoadErrorView.kt
Outdated
Show resolved
Hide resolved
onIconClick = { | ||
backDispatcher?.onBackPressed() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onIconClick = { | |
backDispatcher?.onBackPressed() | |
} | |
onIconClick = backDispatcher?.onBackPressed() |
갠적으로 이걸 더 선호함,,
painter = painterResource(id = R.drawable.ic_empty_default), | ||
modifier = Modifier | ||
.fillMaxWidth() | ||
.padding(horizontal = 64.dp), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
지워주세요 ㅠ
Related issue 🛠
Work Description ✏️
Screenshot 📸
2024-08-23.4.53.55.mov
Uncompleted Tasks 😅
To Reviewers 📢
뷰 오랜만~