[refactor] 에러 뷰, 로딩 뷰 추가 된 디자인 적용 #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2hyunjinn
approved these changes
Aug 16, 2024
jihyunniiii
reviewed
Aug 16, 2024
| painter = painterResource(id = R.drawable.ic_empty_default), | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(horizontal = 64.dp), |
There was a problem hiding this comment.
고정값 패딩을 주지 않고 기본 사이즈로 넣어주셔도 될 것 같아요! 요렇게 하려면 ContentScale.FillWidth 지워줘야함 ~
| contentDescription = null, | ||
| contentScale = ContentScale.FillWidth | ||
| ) | ||
| Spacer(modifier = Modifier.height(30.dp)) |
jihyunniiii
approved these changes
Aug 17, 2024
| contentScale = ContentScale.FillWidth | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(horizontal = 64.dp), |
There was a problem hiding this comment.
얼아라?? ContentScale.FillWidth 이거 지워주면 되는거 아니엇서요?
There was a problem hiding this comment.
ContentScale.FillWidth 이거 지워주면 이미지가 화면을 꽉 채우지 않고 현재 이미지 사이즈만큼의 크기를 가지게 되잖아요?? 그래서 패딩 따로 안 줘두 됨!!
| contentDescription = null, | ||
| contentScale = ContentScale.FillWidth | ||
| ) | ||
| Spacer(modifier = Modifier.height(30.dp)) |
jihyunniiii
reviewed
Aug 20, 2024
| contentScale = ContentScale.FillWidth | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(horizontal = 64.dp), |
There was a problem hiding this comment.
ContentScale.FillWidth 이거 지워주면 이미지가 화면을 꽉 채우지 않고 현재 이미지 사이즈만큼의 크기를 가지게 되잖아요?? 그래서 패딩 따로 안 줘두 됨!!
jihyunniiii
reviewed
Aug 23, 2024
| modifier: Modifier = Modifier | ||
| ) { | ||
| fun DateRoadErrorView() { | ||
| val backDispatcher = LocalOnBackPressedDispatcherOwner.current?.onBackPressedDispatcher |
There was a problem hiding this comment.
이거 변수 선언 안 하고 쓰면 안 되나용? 궁금해서 !
app/src/main/java/org/sopt/dateroad/presentation/ui/component/view/DateRoadErrorView.kt
Outdated
Show resolved
Hide resolved
Comment on lines
38
to
40
| onIconClick = { | ||
| backDispatcher?.onBackPressed() | ||
| } |
There was a problem hiding this comment.
Suggested change
| onIconClick = { | |
| backDispatcher?.onBackPressed() | |
| } | |
| onIconClick = backDispatcher?.onBackPressed() |
갠적으로 이걸 더 선호함,,
| painter = painterResource(id = R.drawable.ic_empty_default), | ||
| modifier = Modifier | ||
| .fillMaxWidth() | ||
| .padding(horizontal = 64.dp), |
app/src/main/java/org/sopt/dateroad/presentation/ui/component/view/DateRoadErrorView.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
2024-08-23.4.53.55.mov
Uncompleted Tasks 😅
To Reviewers 📢
뷰 오랜만~