[feat] 코스 신고하기 웹 뷰 연결 #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihyunniiii
reviewed
Aug 16, 2024
app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailViewModel.kt
Outdated
Show resolved
Hide resolved
jihyunniiii
approved these changes
Aug 27, 2024
app/src/main/java/org/sopt/dateroad/presentation/type/TwoButtonDialogWithDescriptionType.kt
Outdated
Show resolved
Hide resolved
Comment on lines
+55
to
+59
| REPORT_COURSE( | ||
| titleRes = R.string.two_button_dialog_with_description_report_course_title, | ||
| descriptionRes = R.string.two_button_dialog_with_description_report_course_description, | ||
| confirmButtonTextRes = R.string.dialog_report, | ||
| dismissButtonTextRes = R.string.dialog_cancel |
There was a problem hiding this comment.
이 다이얼로그 다른 두 줄 + 버튼 2개짜리 다이얼로그랑 title이랑 description 사이 간격이 다른데 디자인 측에 확인해봐야할 것 같아요!
There was a problem hiding this comment.
이건 만나서 말씀드릴게 있읍니다!
app/src/main/java/org/sopt/dateroad/presentation/type/TwoButtonDialogWithDescriptionType.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/sopt/dateroad/presentation/ui/coursedetail/CourseDetailScreen.kt
Show resolved
Hide resolved
Comment on lines
+318
to
332
| DateRoadBasicBottomSheet( | ||
| isBottomSheetOpen = courseDetailUiState.isDeleteCourseBottomSheetOpen, | ||
| title = stringResource(id = R.string.course_detail_bottom_sheet_title), | ||
| isButtonEnabled = false, | ||
| buttonText = stringResource(id = R.string.course_detail_bottom_sheet_delete), | ||
| itemList = listOf( | ||
| stringResource(id = R.string.course_detail_bottom_sheet_confirm) to { | ||
| onDialogDeleteCourse() | ||
| } | ||
| ), | ||
| onDismissRequest = { dismissDeleteCourseBottomSheet() }, | ||
| onButtonClick = { | ||
| dismissDeleteCourseBottomSheet() | ||
| } | ||
| ) |
There was a problem hiding this comment.
얘도 타입화해도 나쁘지 않을 것 같다는 생각! 생각보다 많이 쓰이네용 리팩할 때 고민해보면 좋을 듯!!
2hyunjinn
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
[코스 삭제 다이얼로그 추가]
2024-08-26.8.27.39.mov
[코스 신고 다이얼로그 추가 및 신고 웹뷰 연결]
2024-08-26.8.28.47.mov
Uncompleted Tasks 😅
To Reviewers 📢
근데 왜 또 썸네일이 첫 번째 사진이 아니지??