-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] 자체 QA - 코스 상세(Course Detail) 뷰 #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
왜 벌써 4시 반이에요?? ㅠㅠ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
밀린 코드 리뷰 다는 중 ㅋㅋ,,
@@ -236,6 +236,7 @@ | |||
<string name="course_detail_bottom_sheet_confirm">글 삭제</string> | |||
<string name="course_detail_bottom_sheet_delete">닫기</string> | |||
<string name="course_detail_bottom_sheet_report">신고하기</string> | |||
<string name="course_detail_total_cost_zero">무지출</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
course_detail_total_cost_zero _cost
네이밍 통일시켜줍시다
object TotalCostZero { | ||
const val ZEROCOST = "무지출" | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data Layer는 presentation Layer에 의존성을 가지면 안 됩니다 (이러면 클린 아키택처 위배)
요거는 Mapper에서만 쓰이는 부분이니 domain Layer로 이동 시켜주는 게 좋을 것 같아요
@@ -18,6 +18,10 @@ object TimePicker { | |||
const val PM = "오후" | |||
} | |||
|
|||
object TotalCostZero { | |||
const val ZEROCOST = "무지출" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ZERO_COST
fun Int.toCost(): String = if (this == 0) { | ||
ZEROCOST | ||
} else { | ||
"${NumberFormat.getNumberInstance(Locale.KOREA).format(this)}${Cost.COST}" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개인적으로 확장성을 고려하여 when문을 사용하는 걸 선호하는 편이지만 갠취니까 안 따라도 되긴 합니당
그리고 0도 상수화 해주는 게 좋아보여요!
Related issue 🛠
Work Description ✏️
Screenshot 📸
금액 태그 적용
무지출 출력
미개봉 코스 아이콘 변경
태그들 영역 비율 설정
Uncompleted Tasks 😅
To Reviewers 📢
힣