[chore] 자체 QA - 코스 상세(Course Detail) 뷰 #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t1nm1ksun
changed the title
jihyunniiii
reviewed
Aug 29, 2024
| @@ -236,6 +236,7 @@ | |||
| <string name="course_detail_bottom_sheet_confirm">글 삭제</string> | |||
| <string name="course_detail_bottom_sheet_delete">닫기</string> | |||
| <string name="course_detail_bottom_sheet_report">신고하기</string> | |||
| <string name="course_detail_total_cost_zero">무지출</string> | |||
There was a problem hiding this comment.
course_detail_total_cost_zero _cost
네이밍 통일시켜줍시다
Comment on lines
+21
to
+24
| object TotalCostZero { | ||
| const val ZEROCOST = "무지출" | ||
| } | ||
|
|
There was a problem hiding this comment.
data Layer는 presentation Layer에 의존성을 가지면 안 됩니다 (이러면 클린 아키택처 위배)
요거는 Mapper에서만 쓰이는 부분이니 domain Layer로 이동 시켜주는 게 좋을 것 같아요
| @@ -18,6 +18,10 @@ object TimePicker { | |||
| const val PM = "오후" | |||
| } | |||
|
|
|||
| object TotalCostZero { | |||
| const val ZEROCOST = "무지출" | |||
Comment on lines
+8
to
+12
| fun Int.toCost(): String = if (this == 0) { | ||
| ZEROCOST | ||
| } else { | ||
| "${NumberFormat.getNumberInstance(Locale.KOREA).format(this)}${Cost.COST}" | ||
| } |
There was a problem hiding this comment.
개인적으로 확장성을 고려하여 when문을 사용하는 걸 선호하는 편이지만 갠취니까 안 따라도 되긴 합니당
그리고 0도 상수화 해주는 게 좋아보여요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
금액 태그 적용
무지출 출력
미개봉 코스 아이콘 변경
태그들 영역 비율 설정
Uncompleted Tasks 😅
To Reviewers 📢
힣