Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore] 온보딩 뷰 디자인 수정 #210

Merged
merged 3 commits into from
Aug 28, 2024
Merged

Conversation

t1nm1ksun
Copy link
Contributor

Related issue 🛠

Work Description ✏️

  • PartialColorText 키워드 수정
  • description 줄바꿈 적용

Screenshot 📸

2024-08-28.4.29.17.mov

Uncompleted Tasks 😅

  • N/A

To Reviewers 📢

2시간 반 남았다 ㅎㅎ

Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

큐에이 끝나고 다 몰아서 볼게 ㅜㅜ

@t1nm1ksun t1nm1ksun merged commit 0fd6b17 into develop Aug 28, 2024
1 check passed
@t1nm1ksun t1nm1ksun deleted the refactor-onboarding branch August 28, 2024 07:40
Copy link
Contributor

@jihyunniiii jihyunniiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이런 것도 바뀌었구낭

@@ -93,7 +93,7 @@ fun OnboardingScreen(
Text(
text = PartialColorText(
stringResource(id = onboardingType.titleRes),
keywords = listOf("포인트", "데이트코스", "100", "다양한"),
keywords = if (page == 0) { listOf("포인트", "데이트 코스", "100", "다양한") } else listOf("100 포인트", "다양한"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 이거 왜 나눠준 거에요?? 그냥 합치면 안 되나 그냥 진짜 궁금해서

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[chore] 온보딩 뷰 디자인 수정
2 participants