[fix] 더보기를 통한 이동 시 스택이 쌓이는 문제 해결 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t1nm1ksun
approved these changes
Sep 2, 2024
Comment on lines
-100
to
+101
| is HomeContract.HomeSideEffect.NavigateToLook -> navigateToLook() | ||
| is HomeContract.HomeSideEffect.NavigateToLook -> navigateToLook(MainNavigationBarItemType.LOOK) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240831_142425.mp4
Uncompleted Tasks 😅
To Reviewers 📢
바텀 네비에 있는 뷰로 화면 전환을 할 때는 바텀 네비를 전환시키는 함수 (navigateMainNavigation)를 사용하여야 하는데 그걸 안 사용하고 일반적으로 뷰를 전환하는 로직을 사용해 화면 전환을 구현하였더라구요 ㅠㅠ (왜 그랬지 ㅜㅜ) navigateMainNavigation을 활용하는 방식으로 수정했는데 혹시 또 바텀 네비 스택 관리가 안 되는 부분이 발견되면 말씀해주세용