[feat] 코스 등록 + 일정 등록 (Enroll) 뷰 앰플리튜드 트래킹 이벤트 코드 심기 #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t1nm1ksun
approved these changes
Sep 17, 2024
Comment on lines
+173
to
+174
| EnrollScreenType.SECOND -> Unit | ||
| EnrollScreenType.THIRD -> Unit |
There was a problem hiding this comment.
개인적으로 when문 선호합니둥 ㅋㅋ
Comment on lines
196
to
232
| when (enrollType) { | ||
| EnrollType.COURSE -> { | ||
| when (uiState.page) { | ||
| EnrollScreenType.FIRST -> AmplitudeUtils.trackEventWithProperties( | ||
| eventName = CLICK_COURSE1_BACK, | ||
| properties = with(uiState.enroll) { mapOf(COURSE_IMAGE to images.isNotEmpty(), COURSE_TITLE to title.isNotEmpty(), COURSE_DATE to date.isNotEmpty(), COURSE_START_TIME to startAt.isNotEmpty(), COURSE_TAGS to tags.isNotEmpty(), DATE_AREA to (city != null)) } | ||
| ) | ||
|
|
||
| EnrollScreenType.SECOND -> AmplitudeUtils.trackEventWithProperties( | ||
| eventName = CLICK_COURSE2_BACK, | ||
| properties = with(uiState.place) { mapOf(DATE_LOCATION to title.isNotEmpty(), DATE_SPEND_TIME to duration.isNotEmpty(), LOCATION_NUM to uiState.enroll.places.size) } | ||
| ) | ||
|
|
||
| EnrollScreenType.THIRD -> AmplitudeUtils.trackEventWithProperties( | ||
| eventName = CLICK_COURSE3_BACK, | ||
| properties = with(uiState.enroll) { mapOf(COURSE_CONTENT to description.length, COURSE_COST to cost.isNotEmpty()) } | ||
| ) | ||
| } | ||
| } | ||
|
|
||
| EnrollType.TIMELINE -> { | ||
| when (uiState.page) { | ||
| EnrollScreenType.FIRST -> AmplitudeUtils.trackEventWithProperties( | ||
| eventName = CLICK_SCHEDULE1_BACK, | ||
| properties = with(uiState.enroll) { mapOf(DATE_TITLE to title.isNotEmpty(), DATE_DATE to date.isNotEmpty(), DATE_TIME to startAt.isNotEmpty(), DATE_TAG_NUM to tags.size, DATE_AREA to (city != null)) } | ||
| ) | ||
|
|
||
| EnrollScreenType.SECOND -> AmplitudeUtils.trackEventWithProperties( | ||
| eventName = CLICK_SCHEDULE2_BACK, | ||
| properties = with(uiState.place) { mapOf(DATE_DETAIL_LOCATION to title.isNotEmpty(), DATE_DETAIL_TIME to duration.isNotEmpty(), DATE_COURSE_NUM to uiState.enroll.places.size) } | ||
| ) | ||
|
|
||
| EnrollScreenType.THIRD -> Unit | ||
| } | ||
| } | ||
| } | ||
| }, |
Comment on lines
97
to
103
| object ViewPath { | ||
| const val HOME = "홈" | ||
| const val TIMELINE = "데이트 일정" | ||
| const val MY_COURSE_READ = "내가 열람한 코스" | ||
| const val COURSE_DETAIL = "코스 상세" | ||
| const val LOOK = "코스 둘러보기" | ||
| } |
There was a problem hiding this comment.
아 여기가 리뷰에 달았던 그거구나!! 고쳐놓을게요!
There was a problem hiding this comment.
맞습니당 하나만 고치고 얼른 머지할게요!!
# Conflicts: # app/src/main/java/org/sopt/dateroad/presentation/ui/enroll/EnrollScreen.kt # app/src/main/java/org/sopt/dateroad/presentation/ui/timeline/TimelineScreen.kt # app/src/main/java/org/sopt/dateroad/presentation/util/Constraints.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Uncompleted Tasks 😅
To Reviewers 📢