Merge pull request #39 from TeamDMU/refactor/fcm

[Refactor] Multicast Message Converter를 Object 클래스로 변경

dmforu-infrastructure/fcm/src/main/kotlin/com/dmforu/fcm/FirebaseMessageSender.kt

@@ -2,19 +2,17 @@ package com.dmforu.fcm
 
 import com.dmforu.domain.message.MessageSender
 import com.dmforu.domain.message.NoticeMessage
-import com.google.firebase.FirebaseApp
 import com.google.firebase.messaging.FirebaseMessaging
 import org.springframework.stereotype.Component
 
 @Component
 internal class FirebaseMessageSender(
-    private val firebaseMessageConverter: FirebaseMessageConverter,
     private val firebaseMessaging: FirebaseMessaging,
 ) : MessageSender {
 
     override fun sendNoticeMessage(message: NoticeMessage, tokens: List<String>) {
 
-        val firebaseMessage = firebaseMessageConverter.buildMessageToNotice(message, tokens)
+        val firebaseMessage = MulticastMessageMapper.mapToMulticastMessage(message, tokens)
 
         firebaseMessaging.sendEachForMulticast(firebaseMessage)
     }

dmforu-infrastructure/fcm/src/main/kotlin/com/dmforu/fcm/FirebaseMessageConverter.kt → dmforu-infrastructure/fcm/src/main/kotlin/com/dmforu/fcm/MulticastMessageMapper.kt

@@ -3,12 +3,10 @@ package com.dmforu.fcm
 import com.dmforu.domain.message.NoticeMessage
 import com.google.firebase.messaging.MulticastMessage
 import com.google.firebase.messaging.Notification
-import org.springframework.stereotype.Component
 
-@Component
-internal class FirebaseMessageConverter {
+internal object MulticastMessageMapper {
 
-    fun buildMessageToNotice(message: NoticeMessage, tokens: List<String>): MulticastMessage {
+    fun mapToMulticastMessage(message: NoticeMessage, tokens: List<String>): MulticastMessage {
         val notification = Notification.builder()
             .setTitle(message.title)
             .setBody(message.body)

dmforu-infrastructure/fcm/src/test/kotlin/com/dmforu/fcm/FirebaseMessageSenderTest.kt

@@ -1,48 +1,50 @@
 package com.dmforu.fcm
 
 import com.dmforu.domain.message.NoticeMessage
+import com.dmforu.domain.notice.Notice
 import com.google.firebase.messaging.FirebaseMessaging
 import com.google.firebase.messaging.MulticastMessage
-import org.junit.jupiter.api.Assertions.*
+import org.junit.jupiter.api.BeforeEach
 import org.junit.jupiter.api.DisplayName
 import org.junit.jupiter.api.Test
-import org.junit.jupiter.api.extension.ExtendWith
 
-import org.mockito.BDDMockito.given
-import org.mockito.InjectMocks
-import org.mockito.Mock
 import org.mockito.Mockito.mock
 import org.mockito.Mockito.verify
-import org.mockito.junit.jupiter.MockitoExtension
-import org.mockito.kotlin.eq
+import org.mockito.kotlin.any
+import org.mockito.kotlin.given
+import java.time.LocalDate
 
-@ExtendWith(MockitoExtension::class)
 class FirebaseMessageSenderTest {
 
-    @Mock
-    private lateinit var firebaseMessageConverter: FirebaseMessageConverter
-
-    @Mock
     private lateinit var firebaseMessaging: FirebaseMessaging
 
-    @InjectMocks
     private lateinit var messageSender: FirebaseMessageSender
 
+    @BeforeEach
+    fun setUp() {
+        firebaseMessaging = mock()
+        messageSender = FirebaseMessageSender(firebaseMessaging)
+    }
+
     @DisplayName("공지를 푸시 알림으로 전송한다.")
     @Test
     fun sendNoticeMessage() {
         // given
-        val message = mock(NoticeMessage::class.java)
-        val multicastMessage = mock(MulticastMessage::class.java)
+        val notice = Notice.of(
+            number = 1,
+            type = "대학",
+            date = LocalDate.now(),
+            title = "공지사항입니다.",
+            author = "관리자",
+            url = "https://www.test.com"
+        )
+        val message = NoticeMessage.createDepartmentNoticeMessage(notice)
         val tokens = listOf("토큰1", "토큰2")
 
-        given(firebaseMessageConverter.buildMessageToNotice(eq(message), eq(tokens))).willReturn(multicastMessage)
-
         // when
         messageSender.sendNoticeMessage(message, tokens)
 
         // then
-        verify(firebaseMessageConverter).buildMessageToNotice(message, tokens)
-        verify(firebaseMessaging).sendEachForMulticast(multicastMessage)
+        verify(firebaseMessaging).sendEachForMulticast(any())
     }
 }