Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] ApiResponse를 Success Response와 Error Response로 분리 #49

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

GiJungPark
Copy link
Contributor

No description provided.

@GiJungPark GiJungPark added REFACTOR Refactor code Deploy Deploy to Dev Server labels Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...n/com/dmforu/api/controller/ApiControllerAdvice.kt 33.33% 3 Missing and 1 partial ⚠️

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #49      +/-   ##
=============================================
- Coverage      86.94%   86.88%   -0.06%     
+ Complexity       240      239       -1     
=============================================
  Files             57       56       -1     
  Lines            697      694       -3     
  Branches          22       22              
=============================================
- Hits             606      603       -3     
  Misses            81       81              
  Partials          10       10              
Files with missing lines Coverage Δ Complexity Δ
...lin/com/dmforu/api/controller/v1/DietController.kt 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...n/com/dmforu/api/controller/v1/NoticeController.kt 100.00% <100.00%> (ø) 4.00 <0.00> (ø)
...com/dmforu/api/controller/v1/ScheduleController.kt 100.00% <100.00%> (ø) 2.00 <1.00> (ø)
...om/dmforu/api/controller/v1/SubscribeController.kt 100.00% <100.00%> (ø) 6.00 <0.00> (ø)
...n/com/dmforu/api/controller/ApiControllerAdvice.kt 43.75% <33.33%> (ø) 4.00 <1.00> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13019f2...d9306f5. Read the comment docs.

@GiJungPark GiJungPark merged commit 1560b6d into develop Nov 4, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deploy Deploy to Dev Server REFACTOR Refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Response 내부에 에러와 성공이 공존하는 부분 Refactor
1 participant