[KW-604] feat: grpc 구현 및 util class 추가#6
Merged
coffeesigma merged 6 commits intodevelopfrom Jun 5, 2025
Hidden character warning
The head ref may contain hidden characters: "KW-604/feat/did-agent\uc5d0-grpc-client-\uad6c\ud604"
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a JSON utility for loading token mappings and implements a gRPC client to update tenant wallet tokens.
- Introduce
JsonToMaputility to read a JSON file into aMap<String, String>. - Implement
HospitalTenantClientto send anUpdateTokensRequestvia gRPC to the tenant service.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/java/com/doubleo/didagent/util/JsonToMap.java | Utility to deserialize JSON into a string map |
| src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java | gRPC client for updating tenant wallet tokens |
Comments suppressed due to low confidence (3)
src/main/java/com/doubleo/didagent/util/JsonToMap.java:9
- [nitpick] Consider adding unit tests for this utility to verify JSON loading behavior and error handling for invalid or missing files.
public class JsonToMap {
src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java:20
- [nitpick] Add JavaDoc to describe the method’s behavior, expected input map format, and possible exceptions.
public UpdateTokensResponse updateTokens(Map<String, String> tokens) {
src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java:15
- [nitpick] Consider adding unit or integration tests to cover the gRPC call, including success and failure scenarios.
public class HospitalTenantClient {
src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java
Show resolved
Hide resolved
src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-604
📌 작업 내용 및 특이사항
📚 참고사항