Skip to content

Comments

[KW-604] feat: grpc 구현 및 util class 추가#6

Merged
coffeesigma merged 6 commits intodevelopfrom
KW-604/feat/did-agent에-grpc-client-구현
Jun 5, 2025

Hidden character warning

The head ref may contain hidden characters: "KW-604/feat/did-agent\uc5d0-grpc-client-\uad6c\ud604"
Merged

[KW-604] feat: grpc 구현 및 util class 추가#6
coffeesigma merged 6 commits intodevelopfrom
KW-604/feat/did-agent에-grpc-client-구현

Conversation

@coffeesigma
Copy link
Contributor

@coffeesigma coffeesigma commented Jun 5, 2025

🔷 Jira Ticket ID

KW-604


📌 작업 내용 및 특이사항

  • tenant에 wallet token 변경할 수 있는 grpc client 구현

📚 참고사항

@coffeesigma coffeesigma requested review from Copilot and willjsw June 5, 2025 06:59
@coffeesigma coffeesigma self-assigned this Jun 5, 2025
@github-actions github-actions bot changed the title feat: grpc 구현 및 util class 추가 [KW-604] feat: grpc 구현 및 util class 추가 Jun 5, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a JSON utility for loading token mappings and implements a gRPC client to update tenant wallet tokens.

  • Introduce JsonToMap utility to read a JSON file into a Map<String, String>.
  • Implement HospitalTenantClient to send an UpdateTokensRequest via gRPC to the tenant service.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/main/java/com/doubleo/didagent/util/JsonToMap.java Utility to deserialize JSON into a string map
src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java gRPC client for updating tenant wallet tokens
Comments suppressed due to low confidence (3)

src/main/java/com/doubleo/didagent/util/JsonToMap.java:9

  • [nitpick] Consider adding unit tests for this utility to verify JSON loading behavior and error handling for invalid or missing files.
public class JsonToMap {

src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java:20

  • [nitpick] Add JavaDoc to describe the method’s behavior, expected input map format, and possible exceptions.
public UpdateTokensResponse updateTokens(Map<String, String> tokens) {

src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java:15

  • [nitpick] Consider adding unit or integration tests to cover the gRPC call, including success and failure scenarios.
public class HospitalTenantClient {

Copy link
Contributor

@willjsw willjsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥹

@coffeesigma coffeesigma merged commit a1f46d1 into develop Jun 5, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants