Skip to content

[KW-659] Kw 659/feat/invitation polling#8

Merged
willjsw merged 20 commits intodevelopfrom
KW-659/feat/invitation-polling
Jun 16, 2025
Merged

[KW-659] Kw 659/feat/invitation polling#8
willjsw merged 20 commits intodevelopfrom
KW-659/feat/invitation-polling

Conversation

@willjsw
Copy link
Contributor

@willjsw willjsw commented Jun 16, 2025

🔷 Jira Ticket ID

KW-659


📌 작업 내용 및 특이사항

Invitation Polling 구현

  • Hospital Invitation 구현(Mediator의 경우 연결 상태를 저장하지 않으므로 별도의 redis 객체 구현 X)
  • Hospital/Mediator invitation polling 을 위한 controller 구현
  • Polling 및 Hospital Invitation 저장 위한 MemberPollService 구현
  • TenantID, PassId, Connection Status 송수신 위한 gRPC interface 모듈 import

📚 참고사항

@willjsw willjsw self-assigned this Jun 16, 2025
@github-actions github-actions bot changed the title Kw 659/feat/invitation polling [KW-659] Kw 659/feat/invitation polling Jun 16, 2025
@willjsw willjsw requested review from coffeesigma and Copilot and removed request for coffeesigma June 16, 2025 04:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements invitation polling functionality and introduces new gRPC service endpoints along with additional client configurations for handling hospital and mediator invitations. Key changes include:

  • Implementation of the AcapyGrpcServiceImpl for issuing verifiable credentials and verifying connection statuses.
  • Addition of new client classes (PassClient and HospitalTenantClient) to handle external gRPC calls.
  • New domain models, DTOs, repository interfaces, and controller endpoints to support invitation polling and DID creation.

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/main/java/com/doubleo/didagent/grpc/server/AcapyGrpcServiceImpl.java Implements gRPC endpoints for issuing VCs and verifying credentials.
src/main/java/com/doubleo/didagent/grpc/client/PassClient.java Adds a gRPC client for updating connection status.
src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java Enhancements to tokens retrieval and hospital ID conversion methods.
src/main/java/com/doubleo/didagent/global/exception/errorcode/AcapyErrorCode.java Defines error codes with their HTTP statuses and messages.
src/main/java/com/doubleo/didagent/dto/response/poll/InvitationInfoResponse.java; DidCreateResponse.java; HospitalInvitationInfoRequest.java; HospitalInvitationCreateRequest.java; DidCreateRequest.java Introduces new DTOs and request/response objects for invitation polling and DID creation.
src/main/java/com/doubleo/didagent/domain/* Adds domain models and repository interfaces for managing member connection and hospital invitation data.
src/main/java/com/doubleo/didagent/controller/* New controllers to expose REST endpoints for polling and webhook reception.
src/main/java/com/doubleo/didagent/agent/client/AcapyClientConfig.java; AcapyClient.java Configures WebClient-based clients for mediator and hospital interactions.
src/main/java/com/doubleo/didagent/agent/AcapyAgent.java Removed unused AcapyAgent class.

Comment on lines 12 to 13
INVITATION_REQUEST_FAILED(HttpStatus.BAD_REQUEST, "invitation 생성 요청에 실패샜습니다"),
DID_PROCESS_FAILED(HttpStatus.BAD_REQUEST, "DID 생성 요청에 실패샜습니다"),
Copy link

Copilot AI Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears there is a typo in the error message; consider replacing "실패샜습니다" with "실패했습니다" for clarity.

Suggested change
INVITATION_REQUEST_FAILED(HttpStatus.BAD_REQUEST, "invitation 생성 요청에 실패샜습니다"),
DID_PROCESS_FAILED(HttpStatus.BAD_REQUEST, "DID 생성 요청에 실패샜습니다"),
INVITATION_REQUEST_FAILED(HttpStatus.BAD_REQUEST, "invitation 생성 요청에 실패했습니다"),
DID_PROCESS_FAILED(HttpStatus.BAD_REQUEST, "DID 생성 요청에 실패했습니다"),

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@coffeesigma coffeesigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

변수들을 객체로 바인딩 한 것이 인상깊습니다

@willjsw willjsw merged commit 688f602 into develop Jun 16, 2025
1 check failed
Copy link
Contributor

@coffeesigma coffeesigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인햇씁니다

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants