[KW-659] Kw 659/feat/invitation polling#8
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements invitation polling functionality and introduces new gRPC service endpoints along with additional client configurations for handling hospital and mediator invitations. Key changes include:
- Implementation of the AcapyGrpcServiceImpl for issuing verifiable credentials and verifying connection statuses.
- Addition of new client classes (PassClient and HospitalTenantClient) to handle external gRPC calls.
- New domain models, DTOs, repository interfaces, and controller endpoints to support invitation polling and DID creation.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/doubleo/didagent/grpc/server/AcapyGrpcServiceImpl.java | Implements gRPC endpoints for issuing VCs and verifying credentials. |
| src/main/java/com/doubleo/didagent/grpc/client/PassClient.java | Adds a gRPC client for updating connection status. |
| src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java | Enhancements to tokens retrieval and hospital ID conversion methods. |
| src/main/java/com/doubleo/didagent/global/exception/errorcode/AcapyErrorCode.java | Defines error codes with their HTTP statuses and messages. |
| src/main/java/com/doubleo/didagent/dto/response/poll/InvitationInfoResponse.java; DidCreateResponse.java; HospitalInvitationInfoRequest.java; HospitalInvitationCreateRequest.java; DidCreateRequest.java | Introduces new DTOs and request/response objects for invitation polling and DID creation. |
| src/main/java/com/doubleo/didagent/domain/* | Adds domain models and repository interfaces for managing member connection and hospital invitation data. |
| src/main/java/com/doubleo/didagent/controller/* | New controllers to expose REST endpoints for polling and webhook reception. |
| src/main/java/com/doubleo/didagent/agent/client/AcapyClientConfig.java; AcapyClient.java | Configures WebClient-based clients for mediator and hospital interactions. |
| src/main/java/com/doubleo/didagent/agent/AcapyAgent.java | Removed unused AcapyAgent class. |
Comment on lines
12
to
13
| INVITATION_REQUEST_FAILED(HttpStatus.BAD_REQUEST, "invitation 생성 요청에 실패샜습니다"), | ||
| DID_PROCESS_FAILED(HttpStatus.BAD_REQUEST, "DID 생성 요청에 실패샜습니다"), |
There was a problem hiding this comment.
It appears there is a typo in the error message; consider replacing "실패샜습니다" with "실패했습니다" for clarity.
Suggested change
| INVITATION_REQUEST_FAILED(HttpStatus.BAD_REQUEST, "invitation 생성 요청에 실패샜습니다"), | |
| DID_PROCESS_FAILED(HttpStatus.BAD_REQUEST, "DID 생성 요청에 실패샜습니다"), | |
| INVITATION_REQUEST_FAILED(HttpStatus.BAD_REQUEST, "invitation 생성 요청에 실패했습니다"), | |
| DID_PROCESS_FAILED(HttpStatus.BAD_REQUEST, "DID 생성 요청에 실패했습니다"), |
src/main/java/com/doubleo/didagent/global/exception/errorcode/AcapyErrorCode.java
Outdated
Show resolved
Hide resolved
coffeesigma
approved these changes
Jun 16, 2025
Contributor
coffeesigma
left a comment
There was a problem hiding this comment.
변수들을 객체로 바인딩 한 것이 인상깊습니다
src/main/java/com/doubleo/didagent/domain/repository/HospitalInvitationRepository.java
Show resolved
Hide resolved
src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java
Outdated
Show resolved
Hide resolved
src/main/java/com/doubleo/didagent/grpc/client/HospitalTenantClient.java
Show resolved
Hide resolved
midday2612
reviewed
Jun 16, 2025
src/main/java/com/doubleo/didagent/global/exception/errorcode/AcapyErrorCode.java
Outdated
Show resolved
Hide resolved
src/main/java/com/doubleo/didagent/controller/MemberPollController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/doubleo/didagent/controller/MemberPollController.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-659
📌 작업 내용 및 특이사항
Invitation Polling 구현
📚 참고사항