Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a webhook handler for ACA-Py to manage connection state updates, DID creation/registration, and VC issuance.
- Implements
AcapyWebhookServicewith handlers for connection, credential, and out-of-band webhooks - Adds new DTOs for ACA-Py request/response payloads
- Updates controller and agent classes to route and log incoming webhooks
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| service/AcapyWebhookService.java | New webhook processing flows for connection, VC, OOB |
| controller/AcapyWebhookController.java | Endpoints wired to webhook service with logging |
| dto/request & dto/response packages | Records for mediator and hospital create/issue flows |
| agent/HospitalAgent.java & agent/MediatorAgent.java | Calls to ACA-Py endpoints for invitations, DIDs, VCs |
| dto/request/DidCreateRequest.java & response/DidCreateResponse.java | Deleted legacy DID DTOs |
Comments suppressed due to low confidence (1)
src/main/java/com/doubleo/didagent/agent/MediatorAgent.java:33
- [nitpick] The error message references 'MemberConnection fetch' but this method creates a mediator invitation; update the message for clarity.
log.error(
"Mediator MemberConnection fetch error: {}",
error.getMessage());
src/main/java/com/doubleo/didagent/service/AcapyWebhookService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/doubleo/didagent/service/AcapyWebhookService.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
….java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
coffeesigma
approved these changes
Jun 16, 2025
Contributor
coffeesigma
left a comment
There was a problem hiding this comment.
장인정신이 보이는 코드네요...
다 만드느라 고생하셨습니다
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-682
📌 작업 내용 및 특이사항
📚 참고사항