Skip to content

Comments

[KW-638] feat/log service grpc server 구현#2

Merged
coffeesigma merged 4 commits intodevelopfrom
KW-638/feat/Log-service-grpc-server-구현
Jun 10, 2025

Hidden character warning

The head ref may contain hidden characters: "KW-638/feat/Log-service-grpc-server-\uad6c\ud604"
Merged

[KW-638] feat/log service grpc server 구현#2
coffeesigma merged 4 commits intodevelopfrom
KW-638/feat/Log-service-grpc-server-구현

Conversation

@coffeesigma
Copy link
Contributor

@coffeesigma coffeesigma commented Jun 10, 2025

🔷 Jira Ticket ID

KW-638


📌 작업 내용 및 특이사항

  • log 저장하는 grpc server 구현

📚 참고사항

@coffeesigma coffeesigma self-assigned this Jun 10, 2025
@github-actions github-actions bot changed the title feat/log service grpc server 구현 [KW-638] feat/log service grpc server 구현 Jun 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Implements a gRPC server for persisting different log types and adds timestamp conversion utilities.

  • Adds LogGrpcServiceImpl with methods to handle issued, entry, and building entry logs
  • Introduces TimestampUtils for converting between Protobuf Timestamp and LocalDateTime
  • Uses repositories to persist domain objects and returns generated IDs in gRPC responses

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/main/java/com/doubleo/logservice/grpc/server/LogGrpcServiceImpl.java New gRPC service implementation to save issued, enter, and building entry logs
src/main/java/com/doubleo/logservice/global/util/TimestampUtils.java Utility class to convert Protobuf Timestamp to/from LocalDateTime
Comments suppressed due to low confidence (4)

src/main/java/com/doubleo/logservice/grpc/server/LogGrpcServiceImpl.java:72

  • [nitpick] An inline TODO comment in Korean is left next to this line; consider replacing it with a standardized TODO or implementing visit category handling now for clarity and consistency.
EnterLog.createEnterLog(...)); // visitcategory 추가 필요

src/main/java/com/doubleo/logservice/grpc/server/LogGrpcServiceImpl.java:33

  • Add unit or integration tests for these new gRPC endpoints (createIssuedLog, createEnterLog, createBuildingEnterLog) to verify persistence logic and response values.
@Override

src/main/java/com/doubleo/logservice/global/util/TimestampUtils.java:14

  • Introduce unit tests for toLocalDateTime and fromLocalDateTime to cover null handling and correct epoch-second/nanosecond conversions.
public static LocalDateTime toLocalDateTime(Timestamp timestamp) {

src/main/java/com/doubleo/logservice/grpc/server/LogGrpcServiceImpl.java:90

  • The Direction enum is referenced but not imported; add the appropriate import (e.g., import com.doubleo.logservice.global.enums.Direction;) to ensure the code compiles.
Direction.valueOf(request.getDirection()),

Copy link
Contributor

@midday2612 midday2612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enter log에 visitcategory 필드 추가했습니다. grpc도 바로 반영하시면 될 거 같아요!

Copy link
Contributor

@midday2612 midday2612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@coffeesigma coffeesigma merged commit c034ba5 into develop Jun 10, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants