[KW-638] feat/log service grpc server 구현#2
Merged
coffeesigma merged 4 commits intodevelopfrom Jun 10, 2025
Hidden character warning
The head ref may contain hidden characters: "KW-638/feat/Log-service-grpc-server-\uad6c\ud604"
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Implements a gRPC server for persisting different log types and adds timestamp conversion utilities.
- Adds
LogGrpcServiceImplwith methods to handle issued, entry, and building entry logs - Introduces
TimestampUtilsfor converting between ProtobufTimestampandLocalDateTime - Uses repositories to persist domain objects and returns generated IDs in gRPC responses
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/com/doubleo/logservice/grpc/server/LogGrpcServiceImpl.java | New gRPC service implementation to save issued, enter, and building entry logs |
| src/main/java/com/doubleo/logservice/global/util/TimestampUtils.java | Utility class to convert Protobuf Timestamp to/from LocalDateTime |
Comments suppressed due to low confidence (4)
src/main/java/com/doubleo/logservice/grpc/server/LogGrpcServiceImpl.java:72
- [nitpick] An inline TODO comment in Korean is left next to this line; consider replacing it with a standardized TODO or implementing visit category handling now for clarity and consistency.
EnterLog.createEnterLog(...)); // visitcategory 추가 필요
src/main/java/com/doubleo/logservice/grpc/server/LogGrpcServiceImpl.java:33
- Add unit or integration tests for these new gRPC endpoints (
createIssuedLog,createEnterLog,createBuildingEnterLog) to verify persistence logic and response values.
@Override
src/main/java/com/doubleo/logservice/global/util/TimestampUtils.java:14
- Introduce unit tests for
toLocalDateTimeandfromLocalDateTimeto cover null handling and correct epoch-second/nanosecond conversions.
public static LocalDateTime toLocalDateTime(Timestamp timestamp) {
src/main/java/com/doubleo/logservice/grpc/server/LogGrpcServiceImpl.java:90
- The
Directionenum is referenced but not imported; add the appropriate import (e.g.,import com.doubleo.logservice.global.enums.Direction;) to ensure the code compiles.
Direction.valueOf(request.getDirection()),
midday2612
reviewed
Jun 10, 2025
Contributor
midday2612
left a comment
There was a problem hiding this comment.
enter log에 visitcategory 필드 추가했습니다. grpc도 바로 반영하시면 될 거 같아요!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-638
📌 작업 내용 및 특이사항
📚 참고사항