Skip to content

[KW-639] feat: log, stats 삭제 및 log grpc client 구현, 대체#48

Merged
coffeesigma merged 1 commit intodevelopfrom
KW-639/feat/pass에서-log-제거-및-grpc-설정
Jun 10, 2025

Hidden character warning

The head ref may contain hidden characters: "KW-639/feat/pass\uc5d0\uc11c-log-\uc81c\uac70-\ubc0f-grpc-\uc124\uc815"
Merged

[KW-639] feat: log, stats 삭제 및 log grpc client 구현, 대체#48
coffeesigma merged 1 commit intodevelopfrom
KW-639/feat/pass에서-log-제거-및-grpc-설정

Conversation

@coffeesigma
Copy link
Contributor

@coffeesigma coffeesigma commented Jun 10, 2025

🔷 Jira Ticket ID

KW-639


📌 작업 내용 및 특이사항

  • log 관련 삭제 및 log 저장 로직 grpc로 대체

📚 참고사항

@coffeesigma coffeesigma self-assigned this Jun 10, 2025
@github-actions github-actions bot changed the title feat: log, stats 삭제 및 log grpc client 구현, 대체 [KW-639] feat: log, stats 삭제 및 log grpc client 구현, 대체 Jun 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all log and stats related code in favor of a new gRPC client implementation for log operations. Key changes include the deletion of repositories, domain models, stream producers/consumers, and the log controller that previously handled log-related API endpoints.

Reviewed Changes

Copilot reviewed 58 out of 58 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/main/java/com/doubleo/passservice/domain/log/repository/IssuedLogAreaRepository.java Removed repository for issued log areas
src/main/java/com/doubleo/passservice/domain/log/repository/EnterLogRepository.java Removed repository for enter logs
src/main/java/com/doubleo/passservice/domain/log/repository/BuildingEnterLogRepository.java Removed repository for building enter logs and related queries
src/main/java/com/doubleo/passservice/domain/log/producer/BuildingEnterLogStreamProducer.java Removed stream producer for building enter logs
src/main/java/com/doubleo/passservice/domain/log/producer/AreaEnterLogStreamProducer.java Removed stream producer for area enter logs
src/main/java/com/doubleo/passservice/domain/log/dto/response/* Removed various log response DTOs
src/main/java/com/doubleo/passservice/domain/log/dto/request/* Removed log request DTOs
src/main/java/com/doubleo/passservice/domain/log/domain/* Removed log-related domain classes (IssuedLog, EnterLog, BuildingEnterLog, etc.)
src/main/java/com/doubleo/passservice/domain/log/controller/LogController.java Removed controller exposing log API endpoints
src/main/java/com/doubleo/passservice/domain/log/consumer/* Removed consumers handling log stream processing
Comments suppressed due to low confidence (3)

src/main/java/com/doubleo/passservice/domain/log/controller/LogController.java:1

  • The removal of LogController eliminates public API endpoints for log operations. Ensure that the new gRPC client implementation fully covers these functionalities and that dependent clients are updated accordingly.
package com.doubleo.passservice.domain.log.controller;

src/main/java/com/doubleo/passservice/domain/log/consumer/BuildingEnterLogConsumer.java:1

  • Deletion of BuildingEnterLogConsumer indicates a change in log processing. Verify that the new gRPC client handles stream consumption and message acknowledgment reliably to prevent processing gaps.
package com.doubleo.passservice.domain.log.consumer;

src/main/java/com/doubleo/passservice/domain/log/repository/IssuedLogAreaRepository.java:1

  • The removal of IssuedLogAreaRepository suggests a migration away from JPA-based log storage. Ensure that all log-related data flows are migrated to the new implementation to maintain system integrity.
package com.doubleo.passservice.domain.log.repository;

Copy link
Contributor

@midday2612 midday2612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다!

@coffeesigma coffeesigma merged commit 6dde5f9 into develop Jun 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants