[KW-639] feat: log, stats 삭제 및 log grpc client 구현, 대체#48
Merged
coffeesigma merged 1 commit intodevelopfrom Jun 10, 2025
Hidden character warning
The head ref may contain hidden characters: "KW-639/feat/pass\uc5d0\uc11c-log-\uc81c\uac70-\ubc0f-grpc-\uc124\uc815"
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes all log and stats related code in favor of a new gRPC client implementation for log operations. Key changes include the deletion of repositories, domain models, stream producers/consumers, and the log controller that previously handled log-related API endpoints.
Reviewed Changes
Copilot reviewed 58 out of 58 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/com/doubleo/passservice/domain/log/repository/IssuedLogAreaRepository.java | Removed repository for issued log areas |
| src/main/java/com/doubleo/passservice/domain/log/repository/EnterLogRepository.java | Removed repository for enter logs |
| src/main/java/com/doubleo/passservice/domain/log/repository/BuildingEnterLogRepository.java | Removed repository for building enter logs and related queries |
| src/main/java/com/doubleo/passservice/domain/log/producer/BuildingEnterLogStreamProducer.java | Removed stream producer for building enter logs |
| src/main/java/com/doubleo/passservice/domain/log/producer/AreaEnterLogStreamProducer.java | Removed stream producer for area enter logs |
| src/main/java/com/doubleo/passservice/domain/log/dto/response/* | Removed various log response DTOs |
| src/main/java/com/doubleo/passservice/domain/log/dto/request/* | Removed log request DTOs |
| src/main/java/com/doubleo/passservice/domain/log/domain/* | Removed log-related domain classes (IssuedLog, EnterLog, BuildingEnterLog, etc.) |
| src/main/java/com/doubleo/passservice/domain/log/controller/LogController.java | Removed controller exposing log API endpoints |
| src/main/java/com/doubleo/passservice/domain/log/consumer/* | Removed consumers handling log stream processing |
Comments suppressed due to low confidence (3)
src/main/java/com/doubleo/passservice/domain/log/controller/LogController.java:1
- The removal of LogController eliminates public API endpoints for log operations. Ensure that the new gRPC client implementation fully covers these functionalities and that dependent clients are updated accordingly.
package com.doubleo.passservice.domain.log.controller;
src/main/java/com/doubleo/passservice/domain/log/consumer/BuildingEnterLogConsumer.java:1
- Deletion of BuildingEnterLogConsumer indicates a change in log processing. Verify that the new gRPC client handles stream consumption and message acknowledgment reliably to prevent processing gaps.
package com.doubleo.passservice.domain.log.consumer;
src/main/java/com/doubleo/passservice/domain/log/repository/IssuedLogAreaRepository.java:1
- The removal of IssuedLogAreaRepository suggests a migration away from JPA-based log storage. Ensure that all log-related data flows are migrated to the new implementation to maintain system integrity.
package com.doubleo.passservice.domain.log.repository;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-639
📌 작업 내용 및 특이사항
📚 참고사항