[KW-643] feat: admin, mobile pass 분리#49
Merged
coffeesigma merged 1 commit intodevelopfrom Jun 10, 2025
Hidden character warning
The head ref may contain hidden characters: "KW-643/feat/admin-mobile-pass-\ubd84\ub9ac"
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR separates member and admin pass routes by renaming the existing controller for member endpoints and extracting admin-specific endpoints into a new controller.
- Renamed
PassControllertoMemberPassController, removing pending and approval endpoints. - Added
AdminPassControllerto host/admin-passesroutes for pending list and approval. - Injected
TenantValidatoronly in the admin controller for tenant resolution.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/com/doubleo/passservice/domain/pass/controller/MemberPassController.java | Renamed class and removed admin-only endpoints (/pending, /approve). |
| src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java | New controller with admin routes under /admin-passes. |
Comments suppressed due to low confidence (4)
src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java:24
- [nitpick] Method names in Java should use lowerCamelCase; consider renaming
PendingPassListGettogetPendingPassList.
public Page<PendingPassResponse> PendingPassListGet(
src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java:32
- [nitpick] Method names in Java should use lowerCamelCase; consider renaming
GuardianApplicationCreatetoapproveGuardianApplication.
public PassCreateResponse GuardianApplicationCreate(
src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java:24
- [nitpick] This endpoint returns a raw
Pagerather than aResponseEntity<Page<...>>, which differs from member endpoints; consider standardizing response wrapping for consistency.
public Page<PendingPassResponse> PendingPassListGet(
src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java:32
- [nitpick] This endpoint returns a raw
PassCreateResponserather thanResponseEntity<PassCreateResponse>; aligning with other controllers would improve consistency.
public PassCreateResponse GuardianApplicationCreate(
src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-643
📌 작업 내용 및 특이사항
📚 참고사항