Skip to content

[KW-643] feat: admin, mobile pass 분리#49

Merged
coffeesigma merged 1 commit intodevelopfrom
KW-643/feat/admin-mobile-pass-분리
Jun 10, 2025

Hidden character warning

The head ref may contain hidden characters: "KW-643/feat/admin-mobile-pass-\ubd84\ub9ac"
Merged

[KW-643] feat: admin, mobile pass 분리#49
coffeesigma merged 1 commit intodevelopfrom
KW-643/feat/admin-mobile-pass-분리

Conversation

@coffeesigma
Copy link
Contributor

@coffeesigma coffeesigma commented Jun 10, 2025

🔷 Jira Ticket ID

KW-643


📌 작업 내용 및 특이사항

  • pass route 분리

📚 참고사항

@coffeesigma coffeesigma self-assigned this Jun 10, 2025
@github-actions github-actions bot changed the title feat: admin, mobile pass 분리 [KW-643] feat: admin, mobile pass 분리 Jun 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates member and admin pass routes by renaming the existing controller for member endpoints and extracting admin-specific endpoints into a new controller.

  • Renamed PassController to MemberPassController, removing pending and approval endpoints.
  • Added AdminPassController to host /admin-passes routes for pending list and approval.
  • Injected TenantValidator only in the admin controller for tenant resolution.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/main/java/com/doubleo/passservice/domain/pass/controller/MemberPassController.java Renamed class and removed admin-only endpoints (/pending, /approve).
src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java New controller with admin routes under /admin-passes.
Comments suppressed due to low confidence (4)

src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java:24

  • [nitpick] Method names in Java should use lowerCamelCase; consider renaming PendingPassListGet to getPendingPassList.
public Page<PendingPassResponse> PendingPassListGet(

src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java:32

  • [nitpick] Method names in Java should use lowerCamelCase; consider renaming GuardianApplicationCreate to approveGuardianApplication.
public PassCreateResponse GuardianApplicationCreate(

src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java:24

  • [nitpick] This endpoint returns a raw Page rather than a ResponseEntity<Page<...>>, which differs from member endpoints; consider standardizing response wrapping for consistency.
public Page<PendingPassResponse> PendingPassListGet(

src/main/java/com/doubleo/passservice/domain/pass/controller/AdminPassController.java:32

  • [nitpick] This endpoint returns a raw PassCreateResponse rather than ResponseEntity<PassCreateResponse>; aligning with other controllers would improve consistency.
public PassCreateResponse GuardianApplicationCreate(

Copy link
Contributor

@midday2612 midday2612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@coffeesigma coffeesigma merged commit 5bf887b into develop Jun 10, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants