Skip to content

[KW-647] feat: fcm과 알림 저장 로직 분리, 메세지 상세화#52

Merged
coffeesigma merged 3 commits intodevelopfrom
KW-647/feat/FCM-메세지-상세화
Jun 11, 2025

Hidden character warning

The head ref may contain hidden characters: "KW-647/feat/FCM-\uba54\uc138\uc9c0-\uc0c1\uc138\ud654"
Merged

[KW-647] feat: fcm과 알림 저장 로직 분리, 메세지 상세화#52
coffeesigma merged 3 commits intodevelopfrom
KW-647/feat/FCM-메세지-상세화

Conversation

@coffeesigma
Copy link
Contributor

@coffeesigma coffeesigma commented Jun 11, 2025

🔷 Jira Ticket ID

KW-647


📌 작업 내용 및 특이사항

  • FCM service에서 알림 저장 로직 분리..
  • 메세지 상세화

📚 참고사항

@coffeesigma coffeesigma self-assigned this Jun 11, 2025
@github-actions github-actions bot changed the title feat: fcm과 알림 저장 로직 분리, 메세지 상세화 [KW-647] feat: fcm과 알림 저장 로직 분리, 메세지 상세화 Jun 11, 2025
Copy link
Contributor

@midday2612 midday2612 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다.

@coffeesigma coffeesigma merged commit 5f02a9f into develop Jun 11, 2025
1 check passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates FCM push logic from database persistence and enhances notification messages with more detailed titles and contents.

  • Moved MemberNotificationRepository saves out of FcmService into PassServiceImpl alongside FCM sends
  • Expanded notification constants for multi-parameter guardian application flows
  • Removed memberId from FcmSendRequest and refactored FcmService.sendNotification accordingly

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
PassServiceImpl.java Added database saves for MemberNotification, updated notification constants and message formatting
FcmService.java Removed persistence logic from sendNotification, leaving only FCM dispatch
FcmSendRequest.java Dropped memberId field and related validation annotations
Comments suppressed due to low confidence (4)

src/main/java/com/doubleo/passservice/domain/notification/service/FcmService.java:17

  • The MemberNotificationRepository field is no longer used after moving persistence to PassServiceImpl; consider removing this unused dependency.
private final MemberNotificationRepository memberNotificationRepository;

src/main/java/com/doubleo/passservice/domain/pass/service/PassServiceImpl.java:392

  • [nitpick] You persist a notification for the guardian applicant but do not send an FCM push; consider adding a corresponding fcmService.sendNotification call for consistency.
memberNotificationRepository.save(

src/main/java/com/doubleo/passservice/domain/pass/service/PassServiceImpl.java:388

  • Repeated creation of DateTimeFormatter.ofPattern("yyyy-MM-dd") could be extracted into a static constant to avoid unnecessary allocations.
pass.getStartAt().format(DateTimeFormatter.ofPattern("yyyy-MM-dd"))

src/main/java/com/doubleo/passservice/domain/pass/service/PassServiceImpl.java:260

  • There are new MemberNotificationRepository.save calls for different flows; consider adding unit tests to validate that notifications are persisted alongside FCM sends.
memberNotificationRepository.save(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants