[KW-647] feat: fcm과 알림 저장 로직 분리, 메세지 상세화#52
Merged
coffeesigma merged 3 commits intodevelopfrom Jun 11, 2025
Hidden character warning
The head ref may contain hidden characters: "KW-647/feat/FCM-\uba54\uc138\uc9c0-\uc0c1\uc138\ud654"
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR separates FCM push logic from database persistence and enhances notification messages with more detailed titles and contents.
- Moved MemberNotificationRepository saves out of FcmService into PassServiceImpl alongside FCM sends
- Expanded notification constants for multi-parameter guardian application flows
- Removed
memberIdfromFcmSendRequestand refactoredFcmService.sendNotificationaccordingly
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PassServiceImpl.java | Added database saves for MemberNotification, updated notification constants and message formatting |
| FcmService.java | Removed persistence logic from sendNotification, leaving only FCM dispatch |
| FcmSendRequest.java | Dropped memberId field and related validation annotations |
Comments suppressed due to low confidence (4)
src/main/java/com/doubleo/passservice/domain/notification/service/FcmService.java:17
- The
MemberNotificationRepositoryfield is no longer used after moving persistence to PassServiceImpl; consider removing this unused dependency.
private final MemberNotificationRepository memberNotificationRepository;
src/main/java/com/doubleo/passservice/domain/pass/service/PassServiceImpl.java:392
- [nitpick] You persist a notification for the guardian applicant but do not send an FCM push; consider adding a corresponding
fcmService.sendNotificationcall for consistency.
memberNotificationRepository.save(
src/main/java/com/doubleo/passservice/domain/pass/service/PassServiceImpl.java:388
- Repeated creation of
DateTimeFormatter.ofPattern("yyyy-MM-dd")could be extracted into a static constant to avoid unnecessary allocations.
pass.getStartAt().format(DateTimeFormatter.ofPattern("yyyy-MM-dd"))
src/main/java/com/doubleo/passservice/domain/pass/service/PassServiceImpl.java:260
- There are new
MemberNotificationRepository.savecalls for different flows; consider adding unit tests to validate that notifications are persisted alongside FCM sends.
memberNotificationRepository.save(
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-647
📌 작업 내용 및 특이사항
📚 참고사항