[KW-668] feat: acapy connection id 저장 로직#55
Merged
midday2612 merged 5 commits intodevelopfrom Jun 16, 2025
Merged
Conversation
github-actions
bot
changed the title
midday2612
force-pushed
the
KW-668/feat/pass-service-connection-id
branch
from
da4afe4 to
b20344c
Compare
midday2612
force-pushed
the
KW-668/feat/pass-service-connection-id
branch
from
04449b5 to
5d22411
Compare
midday2612
force-pushed
the
KW-668/feat/pass-service-connection-id
branch
from
5d22411 to
7ce5c02
Compare
willjsw
requested changes
Jun 13, 2025
Contributor
willjsw
left a comment
willjsw
left a comment
There was a problem hiding this comment.
고생하셨습니다! 다만 PassGrpcServiceImpl 이 너무 많은 책임을 지고 있는 것 같습니다. 가능하다면 logging 과 fcm 알람 처리는 분리하는게 좋아보입니다.
| log.warn("환자 멤버가 존재하지 않아 알림을 생략합니다."); | ||
| } | ||
|
|
||
| UpdateConnectionStatusResponse response; |
Contributor
There was a problem hiding this comment.
P4: try 문 안에 넣어서 선언과 정의를 동시에 하면 코드가 더 보기 좋을 것 같습니다: )
|
|
||
| pass.updateDidConnectionId(connectionId); | ||
| pass.updateStatus(IssuanceStatus.ISSUED); | ||
| passRepository.save(pass); |
Contributor
There was a problem hiding this comment.
P4: 객체 자체에서 생성자를 통한 수정이 일어나는 경우, jpa가 변경점을 자동 감지해 반영하기 때문에, save를 명시하지 않아도 저장이 됩니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-668
📌 작업 내용 및 특이사항
📚 참고사항