[KW-676] feat: getConnectionIdByPassId grpc server#56
Merged
midday2612 merged 1 commit intoKW-668/feat/pass-service-connection-idfrom Jun 16, 2025
Conversation
github-actions
bot
changed the title
willjsw
approved these changes
Jun 16, 2025
Comment on lines
+153
to
+156
| Pass pass = | ||
| passRepository | ||
| .findById(passId) | ||
| .orElseThrow(() -> new CommonException(PassErrorCode.PASS_NOT_FOUND)); |
Contributor
There was a problem hiding this comment.
P4: 클래스 내에서 반복적으로 사용되는 엔티티 조회 로직은 별도의 util 메소드로 분리해 코드 중복을 제거하는 것도 좋아보입니다:)
midday2612
merged commit 960c655
into
KW-668/feat/pass-service-connection-id
2 checks passed
midday2612
added a commit
that referenced
this pull request
Jun 16, 2025
* KW-668/feat: acapy connection id 저장 로직 * KW-668/feat: passGrpcServiceImpl 작성 * KW-668/feat: grpc client 및 vc 발급 로직 반영 * KW-668/feat: issued 상태일 때 알림 및 로그 저장 * KW-676/feat: getConnectionIdByPassId grpc server (#56)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔷 Jira Ticket ID
KW-676
📌 작업 내용 및 특이사항
📚 참고사항