Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blood fog diffuser #1181

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Blood fog diffuser #1181

merged 1 commit into from
Nov 8, 2023

Conversation

Cheaterpaul
Copy link
Member

@Cheaterpaul Cheaterpaul commented Feb 18, 2023

depends on #1278
close #1104

Adds a fog diffuser that emits fog for vampires covering 5x5 chunks.

The diffuser needs to be interacted with once with pure blood to start it up.

Todo:

  • model/textures
  • recipe
  • balancing

@maxanier
Copy link
Member

maxanier commented Mar 4, 2023

Nice!
Regarding recipe/balancing I have the following thought:
It requires some unique drop from the mother. Thereby it should be fairly rare and hard to obtain. Making it cover maybe 3x3 or maybe a "circle" with 5 chunks of diameter should cover a small base. Maybe it could even be larger.

I am unsure about the boosting part though. It seems very annoying to always remember to refill your generator. The fog is something you want to have long term, so you would have to constantly refill it.

@supermike1999
Copy link

How rare would this mother/boss be? like a special boss that only spawns rarely, or one that you force spawn in like the wither/ender dragon? for the range of it, maybe have it a 5x5 area, but you can upgrade it to a better version of what a vampire controlled village totem gives.

I agree with the idea of you shouldn't need to consistently refill the diffusor, since garlic diffusors have the same idea of not needing to be refilled.

@Cheaterpaul
Copy link
Member Author

The diffuser now has a constant range but it needs to be started up by interacting with a pure blood. I did not want the diffuser to work out of the box, so it requires "fuel". But after inserting fuel the diffuer works forever.

This behaves a little like the beacon which needs to be charged with an item to work.

@Cheaterpaul Cheaterpaul linked an issue Mar 24, 2023 that may be closed by this pull request
@Cheaterpaul Cheaterpaul added the feature Any change that takes more time to implement and test label Apr 12, 2023
@Cheaterpaul
Copy link
Member Author

Cheaterpaul commented Jun 25, 2023

I went through the garlic diffuser code and noticed that garlic diffusers do not really work as they look.

  • the startup progress bar shows should always charge up to 100% before the effect starts, but this does not apply depending on the context. When placing the diffuser the progress already starts at 100% which is set to 77% when fueling it.
  • The fueled state decreases over time, but nothing happens when it reaches 0%. Even after a world reload the garlic diffuser emits garlic when having 0% fuel.

This should be addressed by either change the ui or by correctly implement the process the user expects from the ui.

This should be addressed regardless of this PR

@Cheaterpaul
Copy link
Member Author

2023-10-31_17 49 42

@TheGridExpert
Copy link
Contributor

Is it a thing for hunters?

@Cheaterpaul Cheaterpaul marked this pull request as ready for review November 8, 2023 20:42
@Cheaterpaul Cheaterpaul merged commit c119ca0 into dev Nov 8, 2023
2 checks passed
@Cheaterpaul Cheaterpaul deleted the feature/blood_fog_diffuser branch November 13, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Any change that takes more time to implement and test
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature]: Bloodfog Diffuser
4 participants