Vampirism web api #1220
Merged
Vampirism web api #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Cheaterpaul
commented
Jun 25, 2023
•
Cheaterpaul
commented
- swap contributor api
- allows to enable/disable features remotely in the api
- sends basic telemetry data, if it is not disabled in minecraft and vampirism
- mod version
- minecraft version
- installed mods
- server/client
- automatic update of config values and contributors if pushed to the default branch
Cheaterpaul
force-pushed
the
feature/settings_api
branch
from
6ee2e02
to
9192194
Compare
maxanier
reviewed
Jul 27, 2023
src/main/java/de/teamlapen/vampirism/misc/SettingsProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/de/teamlapen/vampirism/misc/SettingsProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/de/teamlapen/vampirism/misc/SettingsProvider.java
Outdated
Show resolved
Hide resolved
src/main/java/de/teamlapen/vampirism/misc/SettingsProvider.java
Outdated
Show resolved
Hide resolved
- settings and supporter only have optional return types - rename non api methods - remove api version as extra attribute - rename config_values.json to default_remote_config.json
Cheaterpaul
force-pushed
the
feature/settings_api
branch
from
7661995
to
5a9ae06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.