Added: Getting started #37
Conversation
|
Hello @TobiGr, i did write it in java, improve it a little, and added very simple examples :) |
|
What's Up @TobiGr :^) |
|
Hello @TobiGr 😄 |
docs/08_getting_started.md
Outdated
|
|
||
| ```gradle | ||
| // NewPipe Libraries | ||
| implementation 'com.github.TeamNewPipe:NewPipeExtractor:0.21.12' |
There was a problem hiding this comment.
NewPipe versions are prefixed with a 'v', so it should be NewPipeExtractor:v0.21.12
There was a problem hiding this comment.
Why are is the PR trying to merge into the branch feat/getting_started and not master?
You are right, I open new one to merge directly to master ;)
| Note that you could use any http client other then okhttp, but it used here for more simplicity. | ||
|
|
||
|
|
||
| ### Make sure you use Java 11 |
There was a problem hiding this comment.
Does the extractor really have the java 11 requirement? I thought that it didn't even support the full Java 8 feature set.
There was a problem hiding this comment.
For some reason I wasn't able to run it below java 8 for android, I really don't know why..
However this might change when we find a solution ;)
There was a problem hiding this comment.
Also this is what NewPipe itself does!
See https://github.com/TeamNewPipe/NewPipe/blob/dev/app/build.gradle#L82
There was a problem hiding this comment.
For 'normal' java apps, it seems to run fine on java 8, see
https://github.com/cloneconf/newpipe-java-example/blob/c90332e7e34365d2424bb16697f88fbdd784f737/build.gradle#L13 (full example)
| <details> | ||
| <summary>simple implementation</summary> |
There was a problem hiding this comment.
This looks like the DownloaderTestImpl, instead of copying it I would just link it.
https://github.com/TeamNewPipe/NewPipeExtractor/blob/dev/extractor/src/test/java/org/schabi/newpipe/downloader/DownloaderTestImpl.java
|
I close this since I did make a PR to feat not please see the new PR here: #38 |
ghost
closed this
see