[features] roll and offset support#1643
Draft
Deepseasaltyfish wants to merge 24 commits intoTeamOpenIndustry:masterfrom
Draft
[features] roll and offset support#1643Deepseasaltyfish wants to merge 24 commits intoTeamOpenIndustry:masterfrom
Deepseasaltyfish wants to merge 24 commits intoTeamOpenIndustry:masterfrom
Conversation
…ompat, fix crash when spawning train on MinecraftRail in some case
…cept GUI curve drawing and length calculating has been finished
…me other problems
…g, fix interpolate function to fix curve generating, fix curve setting function, correct yaw with z-offset, change storage definition to scaled
…lic, add arrow to curve and shorten button text, fix sway, fix some translation
…lculating problem, update Gui drawing, add new linearize to replace old one
…fix wrong tilt calculating
…om to store RailSettings with a key, add client-side update in Gui oncClose(), store guiOpenType in item and update gui open method
| @@ -0,0 +1,26 @@ | |||
| package cam72cam.immersiverailroading.gui.util; | |||
Member
There was a problem hiding this comment.
Could we let this be in UMC?
| Vec3d particlePos = stock.getPosition().add(VecUtil.rotateWrongYaw(exhaust.center.scale(stock.gauge.scale()), stock.getRotationYaw() + 180)); | ||
|
|
||
| // Vec3d particlePos = stock.getPosition().add(VecUtil.rotateWrongYaw(exhaust.center.scale(stock.gauge.scale()), stock.getRotationYaw() + 180)); | ||
| Vec3d particlePos = stock.getModelMatrix().rotate(Math.toRadians(stock.getRotationRoll()),1, 0, 0).apply(exhaust.center); |
Member
There was a problem hiding this comment.
Why don't we rotate roll in stock.getModelMatrix() directly?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main Feature: Add support for Roll and Offset
This PR depends on:
TeamOpenIndustry/TrackAPI#15(merged)TeamOpenIndustry/ImmersiveRailroadingIntegration#20
TeamOpenIndustry/UniversalModCore#226