Skip to content

[Mainline Feature] Add getRedstoneDirect to access strong signal only #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Goldenfield192 wants to merge 1 commit into
base: 1.12.2-forge
Choose a base branch
from
Open

[Mainline Feature] Add getRedstoneDirect to access strong signal only #223

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/main/java/cam72cam/mod/world/World.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ public float getBlockHardness(Vec3i pos) {
return internal.getBlockState(pos.internal()).getBlockHardness(internal, pos.internal());
}

/** Get max redstone power surrounding this block */
/** Get max redstone power (strong and weak) surrounding this block */
public int getRedstone(Vec3i pos) {
int power = 0;
for (Facing facing : Facing.values()) {
Expand All @@ -578,6 +578,19 @@ public int getRedstone(Vec3i pos) {
return power;
}

/**
* Get max strong redstone power surrounding this block
* <p>
* Sometimes attempts to get weak power may trap us into infinite loop, use this in that circumstance
* */
public int getRedstoneDirect(Vec3i pos) {
int power = 0;
for (Facing facing : Facing.values()) {
power = Math.max(power, internal.getStrongPower(pos.offset(facing).internal(), facing.internal));
}
return power;
}

/** If the sky is visible at this position */
public boolean canSeeSky(Vec3i position) {
return internal.canSeeSky(position.internal());
Expand Down