Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refac] 코드리뷰 적용 및 패키지 구조 변경 #43

Merged
merged 9 commits into from
Jan 10, 2024
Merged

Conversation

Parkjyun
Copy link
Collaborator

Related Issue 📌

Description ✔️

  • BusinessException => CustomException으로 변경
  • NaverUtil 패키지 구조 변경
  • orElseThrow 중복 되는 메서드 리팩토링
  • ErrorMessage 변경
  • ApiResponse에 JsonIgnore 삭제

To Reviewers

@Parkjyun Parkjyun requested a review from tkdwns414 January 10, 2024 08:14
@Parkjyun Parkjyun self-assigned this Jan 10, 2024
Copy link
Collaborator

@tkdwns414 tkdwns414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Parkjyun Parkjyun merged commit 8d8edf6 into develop Jan 10, 2024
1 check passed
@tkdwns414 tkdwns414 deleted the refac/34 branch January 18, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refac] 코드 리뷰 적용 및 패키지 구조 변경
2 participants