Add support for ValueTypes.STR_SOUNDSCAPE "soundscape" #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think the test failure is from me, but maybe I'm not understanding the output of it. Some of it seems to be from a tokenizer and the other seems to be from escape sequences? |
|
Okay those test failures are mine. For the valuetype, can you name it |
|
Sure thing! |
ozxybox
force-pushed
the
valuetype-soundscape
branch
from
d3d0648 to
2db97dc
Compare
|
If you merge in, the tests should pass now. |
|
Thanks!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new FGD valuetype for soundscapes. This is needed for a feature I'm working on. I don't think there's really any reason to use this in the HammerAddons FGD, as it would likely end up worse than the current system with choices. I thought about maybe making a polyfill for this, but it would likely end up more messy than what you have now haha.