Skip to content

Boat #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
Pelotrio wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Boat #348

Pelotrio wants to merge 6 commits into from

Conversation

@Pelotrio
Copy link
Contributor

@Pelotrio Pelotrio commented Jun 29, 2022

  • Generates a boat in the underworld dimension
  • Boat spawns with enemies and loot
  • Special loot includes the ancient pearl

Pelotrio added 2 commits June 29, 2022 16:43
@Pelotrio
Removed unused imports
447d102 
Took 15 minutes


Took 3 minutes
@Pelotrio
Boat now generates correctly in underworld dimension
2d56911 
Took 3 hours 30 minutes
@Pelotrio
Copy link
Contributor Author

Pelotrio commented Jun 29, 2022

java_i8KFuZjh8f
First boat generation

murapix
murapix requested changes Jun 29, 2022
View reviewed changes
src/main/java/com/teamwizardry/wizardry/common/network/PacketThriveBlock.java Outdated

public PacketThriveBlock() {
}

Copy link
Collaborator

@murapix murapix Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not have an empty constructor

src/main/java/com/teamwizardry/wizardry/common/world/underworld/UnderWorldBoat.java Outdated
PlacementSettings placementsettings = new PlacementSettings();
Rotation rotation = Rotation.values()[rand.nextInt(Rotation.values().length)];
placementsettings.setIgnoreEntities(false).setMirror(Mirror.NONE).setRotation(rotation);
underworld_boat.addBlocksToWorld(world, position, placementsettings);
Copy link
Collaborator

@murapix murapix Jun 29, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use camelCase for all these variables

@Pelotrio
Copy link
Contributor Author

Pelotrio commented Jun 29, 2022

image
image
Boat now spawns with a few enemies and loot chests (the loot itself is wip). Ancient pearl can be found at the end of the boat similar to the elytra.

@Pelotrio Pelotrio mentioned this pull request Jun 30, 2022
Open
@Pelotrio
Added custom loot table (wip)
a976f9d 
Took 1 hour 19 minutes
@Pelotrio
Copy link
Contributor Author

Pelotrio commented Jun 30, 2022

java_IFHLPESgSc
Example of current loot table (wip)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@murapix murapix murapix requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Pelotrio @murapix