Add option to ignore attributes #49
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw, it looks like there are some outdated NPM packages with security vulnerabilities such as this one: https://nvd.nist.gov/vuln/detail/CVE-2023-45311 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed a way to ignore attributes because I’m diffing markdown-generated html.
Some markdown libraries assign ids to headings based on content. For example:
# headingWill generate:
If a user changes that to
# heading foo, they will only care that the content of the heading changed. They won’t care that the id changed to"heading-foo". They won’t even know that such an id even exists, so causing it to display a modification to the entire heading would only confuse the user. They would only want to see the insertion of “foo”.I did my best to add passing tests but I was unsure about one thing: diff.ts:587,
areNodesEqual(previousSibling, formattingNode)did not require the new option, for some reason. All tests already pass without changing it toareNodesEqual(previousSibling, formattingNode, false, ignoreAttributes). I don’t know why. Maybe I’m missing a test case.