-
Notifications
You must be signed in to change notification settings - Fork 0
Fix/reliability-code #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/reliability-code #190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes floating-point reliability issues in the GeoDDCoordinate class by implementing tolerance-based equality comparison instead of direct double equality comparison.
Key changes:
- Replaced direct floating-point equality (
==) with tolerance-based comparison usingMath.Abs()and a tolerance of 1e-12 degrees - Updated GetHashCode() implementation to ensure consistency with tolerance-based equality by normalizing values
- Added comprehensive test suite to verify floating-point precision handling
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| GeoDDCoordinateTests.cs | Updated namespace to match directory structure |
| FloatingPointTests.cs | Added comprehensive test suite covering floating-point precision scenarios, collection behavior, and edge cases |
| GeoDDCoordinate.cs | Implemented tolerance-based equality operator and consistent hash code generation |
| GeoDDCoordinate.md | Added documentation explaining the floating-point reliability fix and implementation details |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test Summary 4 files 4 suites 1s ⏱️ Results for commit 26c4a2f. ♻️ This comment has been updated with latest results. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
BREAKING CHANGE: Removed support for .NET 5.0, .NET Standard, and .NET Framework. Minimum supported version is now .NET 6.0.
BREAKING CHANGE: renamed DistanceUnit.kilometer to DistanceUnit.Kilometer
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
🚀 Stryker report generated 🚀 |
|
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |



Fix Floating-Point Reliability issue in GeoDDCoordinate
Checklist before requesting a review