Skip to content

Keyframe events #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tbence94 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Keyframe events #1

tbence94 wants to merge 5 commits into from

Conversation

@tbence94
Copy link

@tbence94 tbence94 commented Jun 22, 2022

Summary

Added keyframe events to janus videoroom plugin. These events can be used to monitor video resolution changes in the stream.

NOTE: only supports VP8 and VP9 codecs for now... Streams with other codecs will not emit these events.

Example

{
  videoroom: 'keyframe',
  room: 4473808368667781,
  id: 4302698742002272,
  mindex: 1,
  mid: '1',
  resolution: { width: 640, height: 360 }
}

@tbence94 tbence94 requested a review from tgabi333 June 22, 2022 08:28
@tbence94 tbence94 self-assigned this Jun 22, 2022
tgabi333
tgabi333 suggested changes Jun 22, 2022
View reviewed changes
src/plugins/janus_videoroom.c
json_object_set_new(event, "mid", json_string(ps->mid));
json_object_set_new(event, "resolution", janus_vp8_get_keyframe_resolution(payload, plen));

janus_videoroom_notify_participants(participant, event, TRUE);
Copy link

@tgabi333 tgabi333 Jun 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure if we want to update every participant in a room about a keyframe, what if we only send it to the publisher

@tbence94 tbence94 mentioned this pull request Jul 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tgabi333 tgabi333 tgabi333 requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tbence94 tbence94

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tbence94 @tgabi333