Happy Thoughts Api - Danu

[danu38]

(https://js-project-api-zqp9.onrender.com/)

[JennieDalgren]

Hello!

In your frontend I can't login. And there is no way to register. This way I cannot test your project end to end.

Please ping me when you have fixed this.

Keep it up! 🌼

[LindaSchonfeldt]

Really good job, Danushka! I really like how explanatory your comments are. Makes it easy to understand your code and overall it looks really good! 🙂 The only things I can comment on are:

Your architecture:
To make the code more easy to follow and update you could break out a lot of stuff from your server.js. For example, you could follow the MVC (Model–View–Controller) architecture. I’m sure you’ve heard about it. 🙂 Following that architecture you could put your mongoose models in a folder called “models”, your request handling in a folder called “controllers” and your routes in a “routes” folder. This way, server.js is clean (just setup + wiring), while logic and data handling live in their own files.

Route order:
I also read something about organizing your more specific routes first, and your generic /:id routes last inside each route file. This, because the order matters in Express. If you have a dynamic route like /:id, it can accidentally “catch” other requests if placed above more specific routes. So I guess that’s another reason it’s better to separate the routes into different files.

One again, great job!

[danu38]

Hi @JennieDalgren , Login issue fixed now can you review this when you have time?