Caspian PR #7
Open
Caspian PR #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JennieDalgren
approved these changes
Aug 18, 2025
There was a problem hiding this comment.
Really good job with this project. You have done a lot! It feels like you had a good time building this project.
I like the mix between a rigid and structured backend as well as well thought of frontend implementations. I really liked the validation and UX part of the password creation
Looking forward to see what you will do with the final project!
This project is approved with VG
Comment on lines
+78
to
+82
| // Index for better performance on common queries | ||
| thoughtSchema.index({ createdAt: -1 }) // Most recent first | ||
| thoughtSchema.index({ hearts: -1 }) // Most liked first | ||
| thoughtSchema.index({ category: 1 }) // Category filtering | ||
| thoughtSchema.index({ owner: 1 }) // User's thoughts |
Comment on lines
+69
to
+76
| // Virtual for likes count based on likedBy array length | ||
| thoughtSchema.virtual('likesCount').get(function () { | ||
| return this.likedBy ? this.likedBy.length : 0 | ||
| }) | ||
|
|
||
| // Ensure virtual fields are serialized | ||
| thoughtSchema.set('toJSON', { virtuals: true }) | ||
| thoughtSchema.set('toObject', { virtuals: true }) |
There was a problem hiding this comment.
make sure that you can explain virtuals if you're using this approach.
Comment on lines
+29
to
+31
| if (category) { | ||
| query.category = new RegExp(category, 'i') | ||
| } |
There was a problem hiding this comment.
i couldnt see this filter in the frontend? maybe you didnt had time to implement it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render link: https://friendlytwitter-api.onrender.com
Netlify link: https://friendlytwitter.netlify.app/