-
Notifications
You must be signed in to change notification settings - Fork 62
My business website #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
SaraEnderborg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow Asako! i think you have done such a great job with this site. Hard to find anything to comment on. The user experince is really great and the custom inputs, hover states, and button styling give the site a modern and professional feel. The structure of the code is also very clear and easy to read. Over all a super great job! :)
| @@ -0,0 +1,261 @@ | |||
| body { | |||
| font-family: "Montserrat",; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: extra comma after "Montserrat"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I have 'sans-serif;' after ' Montserrat' in my code.. I don't know why it disappeared here. But thanks for noticing!
index.html
Outdated
| <img | ||
| src="./images/lock.png" | ||
| alt="key"> | ||
| <p>Child-friendly AI tools appropriate for yourn lenaers</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: change lenaers to learners.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙈Fixed!
| </label> | ||
| </div> | ||
|
|
||
| <div class="age-box"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is what you wanted it to be like but i was able to check multiple checkboxes at once so just alerting you on that thats possible:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I wanted to be able to check multiple boxes for the users with multiple children:)
|
Thank you so much for the feedback!! |
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure your project looks good on all different widths. On e.g. 690px width it looks a bit broken because some content is too wide.
Well done with the JavaScript and nice addition with the “To top” button.
Change request
- Make your project look good on all widths
Going forward - make sure you have 2 spaces indentation set in VSC. It will make your code easier to read.
form/index.html
Outdated
| <body> | ||
| <div class="signup-form"> | ||
| <form | ||
| action="http://httpbin.org/anything" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure you're using the https method, otherwise most browsers will block this action
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the feedback! I changed here to http method, and I think/hope I fixed the design problem as well. Now the site looks ok in 690px ( I fixed the width of the price section).
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! 💯
Link to my project:
https://ai-compass-business-site.netlify.app/