-
Notifications
You must be signed in to change notification settings - Fork 62
PR Code Review #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
PR Code Review #57
Changes from all commits
0a700d2
57c80cc
ddefdd9
a1fae75
c10aa6e
d6f3409
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,121 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"/> | ||
| <title>Pawsome</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| </head> | ||
| <body> | ||
|
|
||
| <!-- This is the nagvigation part --> | ||
| <nav class="navbar"> | ||
| <div class="logo">Paw Pals 🐾</div> | ||
|
|
||
| <!-- Hamburger menu, yumyum, add more options later? --> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bra att du lämnar kommentarer på varje "del" av koden, det är lätt att hänga med i allt som händer i koden. |
||
| <button class="hamburger" aria-label="Toggle menu"> | ||
| <span class="bar"></span> | ||
| <span class="bar"></span> | ||
| <span class="bar"></span> | ||
| </button> | ||
|
|
||
| <ul class="nav-menu"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Snyggt att man hamnar på varje del av sidan där man trycker. |
||
| <li><a href="#services" class="nav-link">Services</a></li> | ||
| <li><a href="#team" class="nav-link">Team</a></li> | ||
| <li><a href="#signup" class="nav-link">Sign Up</a></li> | ||
| </ul> | ||
| </nav> | ||
|
|
||
| <!-- The Hero header --> | ||
| <header class="hero"> | ||
| <h1>We Walk. They Wag.</h1> | ||
| <a href="#signup" class="btn-cta">Join Now</a> | ||
|
|
||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. kom ihåg clean code, annars ser det bra ut! |
||
| </header> | ||
|
|
||
| <!-- The Services provided --> <!-- maybe change some icons --> | ||
| <section id="services" class="services"> | ||
| <h2>Our Services</h2> | ||
| <div class="grid"> | ||
| <div class="card"><div class="icon">🐾</div><h3>Safe Walks</h3><p>GPS-tracked routes.</p></div> | ||
| <div class="card"><div class="icon">🎾</div><h3>Playtime</h3><p>Fun & exercise.</p></div> | ||
| <div class="card"><div class="icon">🛁</div><h3>Grooming</h3><p>Keep pets fresh.</p></div> | ||
| <div class="card"><div class="icon">🎓</div><h3>Training</h3><p>Obedience & tricks.</p></div> | ||
| </div> | ||
| </section> | ||
|
|
||
| <!-- Team -- dont know if I want to keep it --> <!-- dont forgets to add pics --> | ||
| <section id="team" class="team"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bra användning av id och classnamn, lätt att förstå vad som händer. |
||
| <h2>Meet Our Team</h2> | ||
| <div class="profiles"> | ||
| <div class="member"><img src="images/Luke.jpg" alt="Lead Walker"><h4>Luke</h4><p>Lead Walker</p></div> | ||
| <div class="member"><img src="images/Alice.jpg" alt="Trainer"><h4>Alice</h4><p>Trainer</p></div> | ||
| <div class="member"><img src="images/Carin.jpg" alt="Groomer"><h4>Carin</h4><p>Groomer</p></div> | ||
| </div> | ||
| </section> | ||
|
|
||
| <!-- The form menu--> | ||
| <section id="signup" class="booking"> | ||
| <h2>Sign Up for Paw Pals</h2> | ||
| <form action="https://httpbin.org/anything" method="POST"> | ||
|
Comment on lines
+58
to
+60
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Väldigt snyggt och enkelt att använda ditt formulär. |
||
|
|
||
| <!-- Text fields --> | ||
| <label for="fullname">Full Name</label> | ||
| <input type="text" id="fullname" name="fullname" placeholder="Your full name" required> | ||
|
|
||
| <label for="email">Email Address</label> | ||
| <input type="email" id="email" name="email" placeholder="Your email" required> | ||
|
|
||
| <!-- Password --> | ||
| <label for="password">Create Password</label> | ||
| <input type="password" id="password" name="password" placeholder="Choose a password" required> | ||
|
|
||
| <!-- Radio buttons --> | ||
| <fieldset> | ||
| <legend>Preferred Service</legend> | ||
| <label><input type="radio" name="service" value="walking" required> Walking</label> | ||
| <label><input type="radio" name="service" value="grooming"> Grooming</label> | ||
| <label><input type="radio" name="service" value="training"> Training</label> | ||
| </fieldset> | ||
|
|
||
| <!-- Checkboxes --> | ||
| <fieldset> | ||
| <legend>Extras</legend> | ||
| <label><input type="checkbox" name="extras" value="newsletter"> Subscribe to newsletter</label> | ||
| <label><input type="checkbox" name="extras" value="offers"> Receive special offers</label> | ||
| </fieldset> | ||
|
|
||
| <!-- Date picker --> | ||
| <label for="appointment">Preferred Appointment Date</label> | ||
| <input type="date" id="appointment" name="appointment" required> | ||
|
|
||
| <!-- Submit --> | ||
| <button type="submit">Sign Up 🐾</button> | ||
| </form> | ||
| </section> | ||
|
|
||
| <!-- Footer --> | ||
|
|
||
| <footer> | ||
| <p>© 2025 Paw Pals. All rights reserved.</p> | ||
| </footer> | ||
|
|
||
| <script> | ||
| const hamburger = document.querySelector('.hamburger'); | ||
| const navMenu = document.querySelector('.nav-menu'); | ||
|
|
||
| hamburger.addEventListener('click', () => { | ||
| navMenu.classList.toggle('active'); | ||
| }); | ||
|
|
||
| document.querySelectorAll('.nav-link').forEach(link => { | ||
| link.addEventListener('click', () => { | ||
| navMenu.classList.remove('active'); | ||
| }); | ||
| }); | ||
| </script> | ||
| </body> | ||
| </html> | ||
| </body> | ||
| </html> | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| // JavaScript for the hamburger menu toggle | ||
|
|
||
| const hamburger = document.querySelector('.hamburger'); | ||
| const navMenu = document.querySelector('.nav-menu'); | ||
|
|
||
| hamburger.addEventListener('click', () => { | ||
| navMenu.classList.toggle('active'); | ||
| }); | ||
|
|
||
| // Close the menu when a link is clicked (optional) | ||
| document.querySelectorAll('.nav-link').forEach(link => { | ||
| link.addEventListener('click', () => { | ||
| navMenu.classList.remove('active'); | ||
| }); | ||
| }); | ||
|
Comment on lines
+2
to
+15
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. snyggt att du har javascript kod, man ser hamburgermenyn i mobilt läge dock så kan man inte klicka på hamburgermenyn och få fram nav-bar. Antar att du håller på för fullt med det. Bra jobbat 👍 |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Snygg logo, en snygg detalj som du skulle kunna göra är att göra den klickbar och att du hamnar på "homepage".