-
Notifications
You must be signed in to change notification settings - Fork 62
Gabriella - JS Project Business Site #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…lapse the menu links
Appilistus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really great job with your website! It looks good and I like the business idea as well :)
I also like the pop up modal and overlay, it looks really nice and professional! Good job with the JS code! The code looks clean and easy to follow. It is also really good that you put comments and describe what the code does, maybe consider to put some comments in HTML as well.
One thing I would recommend is to make a folder for all images, it helps keep them organized.
You have done such a great job! You should be proud of what you've accomplished on your very first project!
|
Massive thanks for great feedback! |
…rea outside button
|
Reopening so we can see and review your handin |
HIPPIEKICK
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your hamburger menu looks super! Everything looks and behaves as expected and you’ve implemented Flexbox and CSS Grid in a good way. Keep it up 💪 PS. I would love for the open hamburger menu to go all the way across the page 😇
Kudos for using a forEach loop (you’re ahead!) and the idea with the modals - looks super!
Link to website on Netlify:
https://sportlinksite.netlify.app/